Attachment 372846 Details for Bug 199194 – Patch

[patch] Patch

bug-199194-20190625140705.patch (text/plain), 2.83 KB, created by Aakash Jain on 2019-06-25 11:07:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-06-25 11:07:06 PDT

Size: 2.83 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 246795)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-06-25  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Retry Layout test in case of failures
>+        https://bugs.webkit.org/show_bug.cgi?id=199194
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
>+        (ReRunWebKitTests): Build step to re-run layout tests.
>+        (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
>+        (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
>+        (RunWebKitTestsWithoutPatch.evaluateCommand):
>+
> 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 246795)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -797,9 +797,35 @@ class RunWebKitTests(shell.Test):
>             self.build.results = SUCCESS
>             self.build.buildFinished([message], SUCCESS)
>         else:
>-            self.build.addStepsAfterCurrentStep([ArchiveTestResults(), UploadTestResults(), ExtractTestResults()])
>+            self.build.addStepsAfterCurrentStep([ArchiveTestResults(), UploadTestResults(), ExtractTestResults(), ReRunWebKitTests()])
>         return rc
> 
>+
>+class ReRunWebKitTests(RunWebKitTests):
>+    name = 're-run-layout-tests'
>+
>+    def evaluateCommand(self, cmd):
>+        rc = shell.Test.evaluateCommand(self, cmd)
>+        if rc == SUCCESS:
>+            message = 'Passed layout tests'
>+            self.descriptionDone = message
>+            self.build.results = SUCCESS
>+            self.build.buildFinished([message], SUCCESS)
>+        else:
>+            self.setProperty('patchFailedTests', True)
>+            self.build.addStepsAfterCurrentStep([ArchiveTestResults(), UploadTestResults(identifier='rerun'), ExtractTestResults(identifier='rerun'), UnApplyPatchIfRequired(), CompileWebKitToT(), RunWebKitTestsWithoutPatch()])
>+        return rc
>+
>+
>+class RunWebKitTestsWithoutPatch(RunWebKitTests):
>+    name = 'run-layout-tests-without-patch'
>+
>+    def evaluateCommand(self, cmd):
>+        rc = shell.Test.evaluateCommand(self, cmd)
>+        self.build.addStepsAfterCurrentStep([ArchiveTestResults(), UploadTestResults(identifier='clean-tree'), ExtractTestResults(identifier='clean-tree')])
>+        return rc
>+
>+
> class RunWebKit1Tests(RunWebKitTests):
>     def start(self):
>         self.setCommand(self.command + ['--dump-render-tree'])

Actions: View | Formatted Diff | Diff

Attachments on bug 199194: 372846