Attachment 372826 Details for Bug 199187 – Patch

[patch] Patch

bug-199187-20190625014538.patch (text/plain), 1.72 KB, created by Tim Horton on 2019-06-25 01:45:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Horton

Created: 2019-06-25 01:45:38 PDT

Size: 1.72 KB

patch

obsolete

>Subversion Revision: 246781
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 4e8cb65c9819b9e105671ae00456b75159f7caed..01cd188e7c7f805045f4d05f40dfbd19eedbaad9 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-25  Tim Horton  <timothy_horton@apple.com>
>+
>+        When Caps Lock is enabled on the Smart Keyboard, can't scroll with space or arrow keys
>+        https://bugs.webkit.org/show_bug.cgi?id=199187
>+        <rdar://problem/51521709>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/ios/WKKeyboardScrollingAnimator.mm:
>+        (-[WKKeyboardScrollingAnimator keyboardScrollForEvent:]):
>+        When deciding whether a key event should start a scroll, ignore all
>+        modifiers other than the ones we actually care about (including Caps Lock).
>+
> 2019-06-24  Brady Eidson  <beidson@apple.com>
> 
>         Null deref in WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad.
>diff --git a/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm b/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm
>index c02909a81d025841712fadab3240fff411fe3b90..65cb5b5042e333c98c98b3fbaff40b512848f67e 100644
>--- a/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm
>+++ b/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm
>@@ -243,7 +243,8 @@ - (Optional<WebKit::KeyboardScroll>)keyboardScrollForEvent:(::WebEvent *)event
>         };
>     }();
> 
>-    if (event.modifierFlags & ~allowedModifiers)
>+    auto relevantModifierFlags = WebEventFlagMaskOptionKey | WebEventFlagMaskCommandKey | WebEventFlagMaskShiftKey;
>+    if (event.modifierFlags & relevantModifierFlags & ~allowedModifiers)
>         return WTF::nullopt;
> 
>     auto increment = ^{

Actions: View | Formatted Diff | Diff

Attachments on bug 199187: 372826