Attachment 372804 Details for Bug 199175 – Patch

[patch] Patch

bug-199175-20190624144435.patch (text/plain), 5.91 KB, created by Sihui Liu on 2019-06-24 14:44:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2019-06-24 14:44:36 PDT

Size: 5.91 KB

patch

obsolete

>Subversion Revision: 246753
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8f2a1e8a2f0d400ca2698424b4eff2328f7c74a7..4ebf118e023d38f4c6063273f5c3829f82dbcd03 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-06-24  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Remove WebSQL quirk for nytimes.com
>+        https://bugs.webkit.org/show_bug.cgi?id=199175
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Removed unused code.
>+
>+        * bindings/scripts/CodeGeneratorJS.pm:
>+        (GenerateRuntimeEnableConditionalString):
>+        * bindings/scripts/IDLAttributes.json:
>+        * page/Quirks.cpp:
>+        (WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
>+        (WebCore::Quirks::hasWebSQLSupportQuirk const): Deleted.
>+        * page/Quirks.h:
>+
> 2019-06-24  Antoine Quint  <graouts@apple.com>
> 
>         [Pointer Events WPT] Unskip imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_is_first.html
>diff --git a/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm b/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
>index f29422dcd6e72f999286115fbdcbb06ff559a725..2edb8ab6a82d722828875363bf05913caf5495f5 100644
>--- a/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
>+++ b/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
>@@ -3772,28 +3772,9 @@ sub GenerateRuntimeEnableConditionalString
> 
>         AddToImplIncludes("RuntimeEnabledFeatures.h");
> 
>-        if ($context->extendedAttributes->{EnabledByQuirk}) {
>-            AddToImplIncludes("Document.h");
>-            AddToImplIncludes("Quirks.h");
>-            
>-            assert("EnabledByQuirks can only be used by interfaces only exposed to the Window") if $interface->extendedAttributes->{Exposed} && $interface->extendedAttributes->{Exposed} ne "Window";
>-    
>-            my @quirkFlags = split(/&/, $context->extendedAttributes->{EnabledByQuirk});
>-            my @runtimeFlags = split(/&/, $context->extendedAttributes->{EnabledAtRuntime});
>-            my @quirks;
>-            my @runtimes;
>-            foreach my $flag (@quirkFlags) {
>-                push(@quirks, "downcast<Document>(jsCast<JSDOMGlobalObject*>(" . $globalObjectPtr . ")->scriptExecutionContext())->quirks()." . ToMethodName($flag) . "Quirk()");
>-            }
>-            foreach my $flag (@runtimeFlags) {
>-                push(@runtimes, "RuntimeEnabledFeatures::sharedFeatures()." . ToMethodName($flag) . "Enabled()");
>-            }
>-            push(@conjuncts, "(" . join(" && ", @quirks) . " || " . join(" && ", @runtimes) .")");
>-        } else {
>-            my @flags = split(/&/, $context->extendedAttributes->{EnabledAtRuntime});
>-            foreach my $flag (@flags) {
>-                push(@conjuncts, "RuntimeEnabledFeatures::sharedFeatures()." . ToMethodName($flag) . "Enabled()");
>-            }
>+        my @flags = split(/&/, $context->extendedAttributes->{EnabledAtRuntime});
>+        foreach my $flag (@flags) {
>+            push(@conjuncts, "RuntimeEnabledFeatures::sharedFeatures()." . ToMethodName($flag) . "Enabled()");
>         }
>     }
> 
>diff --git a/Source/WebCore/bindings/scripts/IDLAttributes.json b/Source/WebCore/bindings/scripts/IDLAttributes.json
>index dd9519e2449147bec930c224301be291c9e3b05b..9705c8b48213cd9798c55146413a65a4a2bd7785 100644
>--- a/Source/WebCore/bindings/scripts/IDLAttributes.json
>+++ b/Source/WebCore/bindings/scripts/IDLAttributes.json
>@@ -191,10 +191,6 @@
>             "contextsAllowed": ["interface", "dictionary", "enum", "attribute", "operation", "constant"],
>             "values": ["*"]
>         },
>-        "EnabledByQuirk": {
>-            "contextsAllowed": ["interface", "dictionary", "enum", "attribute", "operation", "constant"],
>-            "values": ["*"]
>-        },
>         "EnabledForContext": {
>             "contextsAllowed": ["attribute", "interface"]
>         },
>diff --git a/Source/WebCore/page/Quirks.cpp b/Source/WebCore/page/Quirks.cpp
>index 6543984a3afe6c5d3f5eb9ec6b2c17048cd0fe01..6fe3b8e9125fcfd56d670ab30774b2d181b1a9ed 100644
>--- a/Source/WebCore/page/Quirks.cpp
>+++ b/Source/WebCore/page/Quirks.cpp
>@@ -169,28 +169,6 @@ bool Quirks::hasBrokenEncryptedMediaAPISupportQuirk() const
>     return m_hasBrokenEncryptedMediaAPISupportQuirk.value();
> }
> 
>-bool Quirks::hasWebSQLSupportQuirk() const
>-{
>-    if (!needsQuirks())
>-        return false;
>-    
>-    if (m_hasWebSQLSupportQuirk)
>-        return m_hasWebSQLSupportQuirk.value();
>-    
>-    auto domain = m_document->securityOrigin().domain().convertToASCIILowercase();
>-    
>-    m_hasWebSQLSupportQuirk = domain == "bostonglobe.com"
>-        || domain.endsWith(".bostonglobe.com")
>-        || domain == "latimes.com"
>-        || domain.endsWith(".latimes.com")
>-        || domain == "washingtonpost.com"
>-        || domain.endsWith(".washingtonpost.com")
>-        || domain == "nytimes.com"
>-        || domain.endsWith(".nytimes.com");
>-    
>-    return m_hasWebSQLSupportQuirk.value();
>-}
>-
> bool Quirks::isTouchBarUpdateSupressedForHiddenContentEditable() const
> {
> #if PLATFORM(MAC)
>diff --git a/Source/WebCore/page/Quirks.h b/Source/WebCore/page/Quirks.h
>index 088b83ea07937f607e8d09f038da48552b65b7c3..0702dfc04764d2c260ca0364bcfc06c1d027473f 100644
>--- a/Source/WebCore/page/Quirks.h
>+++ b/Source/WebCore/page/Quirks.h
>@@ -49,7 +49,6 @@ public:
>     bool needsPerDocumentAutoplayBehavior() const;
>     bool shouldAutoplayForArbitraryUserGesture() const;
>     bool hasBrokenEncryptedMediaAPISupportQuirk() const;
>-    bool hasWebSQLSupportQuirk() const;
> #if ENABLE(TOUCH_EVENTS)
>     bool shouldDispatchSimulatedMouseEvents() const;
>     bool shouldDispatchSimulatedMouseEventsOnTarget(EventTarget*) const;
>@@ -71,7 +70,6 @@ private:
>     WeakPtr<Document> m_document;
> 
>     mutable Optional<bool> m_hasBrokenEncryptedMediaAPISupportQuirk;
>-    mutable Optional<bool> m_hasWebSQLSupportQuirk;
> #if PLATFORM(IOS_FAMILY)
>     mutable Optional<bool> m_needsGMailOverflowScrollQuirk;
>     mutable Optional<bool> m_needsYouTubeOverflowScrollQuirk;

Actions: View | Formatted Diff | Diff

Attachments on bug 199175: 372804