Attachment 372795 Details for Bug 194322 – Patch

[patch] Patch

bug-194322-20190624233231.patch (text/plain), 6.38 KB, created by Alexey Shvayka on 2019-06-24 13:32:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Shvayka

Created: 2019-06-24 13:32:32 PDT

Size: 6.38 KB

patch

obsolete

>Index: JSTests/ChangeLog
>===================================================================
>--- JSTests/ChangeLog	(revision 246762)
>+++ JSTests/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-06-24  Alexey Shvayka  <shvaikalesh@gmail.com>
>+
>+        Add Array.prototype.{flat,flatMap} to unscopables
>+        https://bugs.webkit.org/show_bug.cgi?id=194322
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * stress/unscopables.js: Fix test.
>+        * test262/expectations.yaml: Mark 2 test cases as passing.
>+
> 2019-06-21  Mark Lam  <mark.lam@apple.com>
> 
>         ArraySlice needs to keep the source array alive.
>Index: JSTests/stress/unscopables.js
>===================================================================
>--- JSTests/stress/unscopables.js	(revision 246740)
>+++ JSTests/stress/unscopables.js	(working copy)
>@@ -9,7 +9,7 @@ function test(actual, expected) {
> 
>     test(typeof unscopables, "object");
>     test(unscopables.__proto__, undefined);
>-    test(String(Object.keys(unscopables).sort()), "copyWithin,entries,fill,find,findIndex,includes,keys,values");
>+    test(String(Object.keys(unscopables).sort()), "copyWithin,entries,fill,find,findIndex,flat,flatMap,includes,keys,values");
> }());
> 
> (function () {
>Index: JSTests/test262/expectations.yaml
>===================================================================
>--- JSTests/test262/expectations.yaml	(revision 246740)
>+++ JSTests/test262/expectations.yaml	(working copy)
>@@ -624,9 +624,6 @@ test/built-ins/Array/of/return-abrupt-fr
> test/built-ins/Array/proto-from-ctor-realm.js:
>   default: 'Test262Error: Expected SameValue(ÃÂ«ÃÂ», ÃÂ«ÃÂ») to be true'
>   strict mode: 'Test262Error: Expected SameValue(ÃÂ«ÃÂ», ÃÂ«ÃÂ») to be true'
>-test/built-ins/Array/prototype/Symbol.unscopables/value.js:
>-  default: 'Test262Error: `flat` property value Expected SameValue(ÃÂ«undefinedÃÂ», ÃÂ«trueÃÂ») to be true'
>-  strict mode: 'Test262Error: `flat` property value Expected SameValue(ÃÂ«undefinedÃÂ», ÃÂ«trueÃÂ») to be true'
> test/built-ins/Array/prototype/filter/target-array-with-non-writable-property.js:
>   default: 'TypeError: Attempted to assign to readonly property.'
>   strict mode: 'TypeError: Attempted to assign to readonly property.'
>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 246740)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-06-24  Alexey Shvayka  <shvaikalesh@gmail.com>
>+
>+        Add Array.prototype.{flat,flatMap} to unscopables
>+        https://bugs.webkit.org/show_bug.cgi?id=194322
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * runtime/ArrayPrototype.cpp:
>+        (JSC::ArrayPrototype::finishCreation):
>+
> 2019-06-24  Mark Lam  <mark.lam@apple.com>
> 
>         ArraySlice needs to keep the source array alive.
>Index: Source/JavaScriptCore/runtime/ArrayPrototype.cpp
>===================================================================
>--- Source/JavaScriptCore/runtime/ArrayPrototype.cpp	(revision 246740)
>+++ Source/JavaScriptCore/runtime/ArrayPrototype.cpp	(working copy)
>@@ -132,6 +132,8 @@ void ArrayPrototype::finishCreation(VM& 
>         &vm.propertyNames->builtinNames().fillPublicName(),
>         &vm.propertyNames->builtinNames().findPublicName(),
>         &vm.propertyNames->builtinNames().findIndexPublicName(),
>+        &vm.propertyNames->builtinNames().flatPublicName(),
>+        &vm.propertyNames->builtinNames().flatMapPublicName(),
>         &vm.propertyNames->builtinNames().includesPublicName(),
>         &vm.propertyNames->builtinNames().keysPublicName(),
>         &vm.propertyNames->builtinNames().valuesPublicName()
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 246740)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-06-24  Alexey Shvayka  <shvaikalesh@gmail.com>
>+
>+        Add Array.prototype.{flat,flatMap} to unscopables
>+        https://bugs.webkit.org/show_bug.cgi?id=194322
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * js/array-unscopables-properties-expected.txt:
>+        * js/script-tests/array-unscopables-properties.js:
>+
> 2019-06-24  Greg Doolittle  <gr3g@apple.com>
> 
>         Web Inspector: AXI: Audit: image label test is throwing spurious errors on elements with existing alt attr, but no value: <img alt>
>Index: LayoutTests/js/array-unscopables-properties-expected.txt
>===================================================================
>--- LayoutTests/js/array-unscopables-properties-expected.txt	(revision 246740)
>+++ LayoutTests/js/array-unscopables-properties-expected.txt	(working copy)
>@@ -30,6 +30,14 @@ PASS Array.prototype[Symbol.unscopables]
> PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findIndex").writable is true
> PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findIndex").enumerable is true
> PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findIndex").configurable is true
>+PASS Array.prototype[Symbol.unscopables]["flat"] is true
>+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "flat").writable is true
>+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "flat").enumerable is true
>+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "flat").configurable is true
>+PASS Array.prototype[Symbol.unscopables]["flatMap"] is true
>+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "flatMap").writable is true
>+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "flatMap").enumerable is true
>+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "flatMap").configurable is true
> PASS Array.prototype[Symbol.unscopables]["includes"] is true
> PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "includes").writable is true
> PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "includes").enumerable is true
>Index: LayoutTests/js/script-tests/array-unscopables-properties.js
>===================================================================
>--- LayoutTests/js/script-tests/array-unscopables-properties.js	(revision 246740)
>+++ LayoutTests/js/script-tests/array-unscopables-properties.js	(working copy)
>@@ -12,6 +12,8 @@ let expectedEntries = [
>     "fill",
>     "find",
>     "findIndex",
>+    "flat",
>+    "flatMap",
>     "includes",
>     "keys",
>     "values"

Actions: View | Formatted Diff | Diff

Attachments on bug 194322: 372770 | 372773 | 372775 | 372780 | 372781 | 372784 | 372793 | 372795