Attachment 372779 Details for Bug 199145 – Patch

[patch] Patch

bug-199145-20190624114236.patch (text/plain), 1.75 KB, created by Yusuke Suzuki on 2019-06-24 11:42:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2019-06-24 11:42:37 PDT

Size: 1.75 KB

patch

obsolete

>Subversion Revision: 246706
>diff --git a/Source/bmalloc/ChangeLog b/Source/bmalloc/ChangeLog
>index 9b203e930e1e06f77c7bc8e28e42e89b39ac35a9..bc8db92b2df593049910e1495d238627c81df8a6 100644
>--- a/Source/bmalloc/ChangeLog
>+++ b/Source/bmalloc/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-24  Yusuke Suzuki  <ysuzuki@apple.com>
>+
>+        [bmalloc] IsoHeap shared tier threshold is small
>+        https://bugs.webkit.org/show_bug.cgi?id=199145
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We accidentally picked 3 for the shared tier threshold. While this is OK because the important part of IsoHeap shared tier is putting
>+        small # of shared objects before tiering up to the page-based allocation, increasing this threshold can potentially improve memory footprint.
>+        This patch increases this threshold from 3 to 8. A/B test says that this offers stable 0.25% improvement in PLUM2.
>+
>+        * bmalloc/IsoHeapImpl.h:
>+
> 2019-06-21  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         [bmalloc] IsoTLS Layout extension initializes one IsoTLSEntry twice
>diff --git a/Source/bmalloc/bmalloc/IsoHeapImpl.h b/Source/bmalloc/bmalloc/IsoHeapImpl.h
>index 228fa54c497c99ea995b0d5a649a4a7e1ea22323..86b8b77706723f994f0df77809194165a862c7df 100644
>--- a/Source/bmalloc/bmalloc/IsoHeapImpl.h
>+++ b/Source/bmalloc/bmalloc/IsoHeapImpl.h
>@@ -39,7 +39,7 @@ class BEXPORT IsoHeapImplBase {
>     MAKE_BMALLOCED;
> public:
>     static constexpr unsigned maxAllocationFromShared = 8;
>-    static constexpr unsigned maxAllocationFromSharedMask = maxAllocationFromShared - 1;
>+    static constexpr unsigned maxAllocationFromSharedMask = (1U << maxAllocationFromShared) - 1U;
>     static_assert(maxAllocationFromShared <= bmalloc::alignment, "");
>     static_assert(isPowerOfTwo(maxAllocationFromShared), "");
>

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 199145: 372779