Attachment 372770 Details for Bug 194322 – Patch

[patch] Patch

bug-194322-20190624201416.patch (text/plain), 3.05 KB, created by Alexey Shvayka on 2019-06-24 10:14:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Shvayka

Created: 2019-06-24 10:14:17 PDT

Size: 3.05 KB

patch

obsolete

>Index: JSTests/ChangeLog
>===================================================================
>--- JSTests/ChangeLog	(revision 246738)
>+++ JSTests/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-06-24  Alexey Shvayka  <shvaikalesh@gmail.com>
>+
>+        Add Array.prototype.{flat,flatMap} to unscopables
>+        https://bugs.webkit.org/show_bug.cgi?id=194322
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * test262/expectations.yaml: Mark 2 test cases as passing.
>+
> 2019-06-22  Robin Morisset  <rmorisset@apple.com> and Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         All prototypes should call didBecomePrototype()
>Index: JSTests/test262/expectations.yaml
>===================================================================
>--- JSTests/test262/expectations.yaml	(revision 246738)
>+++ JSTests/test262/expectations.yaml	(working copy)
>@@ -624,9 +624,6 @@ test/built-ins/Array/of/return-abrupt-fr
> test/built-ins/Array/proto-from-ctor-realm.js:
>   default: 'Test262Error: Expected SameValue(ÃÂ«ÃÂ», ÃÂ«ÃÂ») to be true'
>   strict mode: 'Test262Error: Expected SameValue(ÃÂ«ÃÂ», ÃÂ«ÃÂ») to be true'
>-test/built-ins/Array/prototype/Symbol.unscopables/value.js:
>-  default: 'Test262Error: `flat` property value Expected SameValue(ÃÂ«undefinedÃÂ», ÃÂ«trueÃÂ») to be true'
>-  strict mode: 'Test262Error: `flat` property value Expected SameValue(ÃÂ«undefinedÃÂ», ÃÂ«trueÃÂ») to be true'
> test/built-ins/Array/prototype/filter/target-array-with-non-writable-property.js:
>   default: 'TypeError: Attempted to assign to readonly property.'
>   strict mode: 'TypeError: Attempted to assign to readonly property.'
>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 246738)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-06-24  Alexey Shvayka  <shvaikalesh@gmail.com>
>+
>+        Add Array.prototype.{flat,flatMap} to unscopables
>+        https://bugs.webkit.org/show_bug.cgi?id=194322
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * runtime/ArrayPrototype.cpp:
>+        (JSC::ArrayPrototype::finishCreation):
>+
> 2019-06-22  Robin Morisset  <rmorisset@apple.com> and Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         All prototypes should call didBecomePrototype()
>Index: Source/JavaScriptCore/runtime/ArrayPrototype.cpp
>===================================================================
>--- Source/JavaScriptCore/runtime/ArrayPrototype.cpp	(revision 246738)
>+++ Source/JavaScriptCore/runtime/ArrayPrototype.cpp	(working copy)
>@@ -132,6 +132,8 @@ void ArrayPrototype::finishCreation(VM& 
>         &vm.propertyNames->builtinNames().fillPublicName(),
>         &vm.propertyNames->builtinNames().findPublicName(),
>         &vm.propertyNames->builtinNames().findIndexPublicName(),
>+        &vm.propertyNames->builtinNames().flatPublicName(),
>+        &vm.propertyNames->builtinNames().flatMapPublicName(),
>         &vm.propertyNames->builtinNames().includesPublicName(),
>         &vm.propertyNames->builtinNames().keysPublicName(),
>         &vm.propertyNames->builtinNames().valuesPublicName()

Actions: View | Formatted Diff | Diff

Attachments on bug 194322: 372770 | 372773 | 372775 | 372780 | 372781 | 372784 | 372793 | 372795