WebKit Bugzilla
Attachment 372763 Details for
Bug 199160
: [Cocoa] Avoid creating a PlatformMediaSessionManager when the WebProcess is suspended or resumed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-199160-20190624080813.patch (text/plain), 2.29 KB, created by
Per Arne Vollan
on 2019-06-24 08:08:15 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Per Arne Vollan
Created:
2019-06-24 08:08:15 PDT
Size:
2.29 KB
patch
obsolete
>Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 246736) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,18 @@ >+2019-06-24 Per Arne Vollan <pvollan@apple.com> >+ >+ [Cocoa] Avoid creating a PlatformMediaSessionManager when the WebProcess is suspended or resumed >+ https://bugs.webkit.org/show_bug.cgi?id=199160 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ When the WebProcess suspends or resumes, the PlatformMediaSessionManager is notified about this. >+ Avoid creating a new PlatformMediaSessionManager if it does not already exist. >+ >+ * WebProcess/WebProcess.cpp: >+ (WebKit::WebProcess::actualPrepareToSuspend): >+ (WebKit::WebProcess::cancelPrepareToSuspend): >+ (WebKit::WebProcess::processDidResume): >+ > 2019-06-24 Adrian Perez de Castro <aperez@igalia.com> > > [WPE][GTK] Fixes for compilation with unified builds disabled >Index: Source/WebKit/WebProcess/WebProcess.cpp >=================================================================== >--- Source/WebKit/WebProcess/WebProcess.cpp (revision 246656) >+++ Source/WebKit/WebProcess/WebProcess.cpp (working copy) >@@ -1473,7 +1473,8 @@ void WebProcess::actualPrepareToSuspend( > > #if ENABLE(VIDEO) > suspendAllMediaBuffering(); >- PlatformMediaSessionManager::sharedManager().processWillSuspend(); >+ if (auto* platformMediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists()) >+ platformMediaSessionManager->processWillSuspend(); > #endif > > if (!m_suppressMemoryPressureHandler) >@@ -1535,7 +1536,8 @@ void WebProcess::cancelPrepareToSuspend( > #endif > > #if ENABLE(VIDEO) >- PlatformMediaSessionManager::sharedManager().processDidResume(); >+ if (auto* platformMediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists()) >+ platformMediaSessionManager->processDidResume(); > resumeAllMediaBuffering(); > #endif > >@@ -1611,7 +1613,8 @@ void WebProcess::processDidResume() > #endif > > #if ENABLE(VIDEO) >- PlatformMediaSessionManager::sharedManager().processDidResume(); >+ if (auto* platformMediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists()) >+ platformMediaSessionManager->processDidResume(); > resumeAllMediaBuffering(); > #endif > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199160
: 372763