Attachment 372753 Details for Bug 199154 – Patch

[patch] Patch

bug-199154-20190624090341.patch (text/plain), 2.67 KB, created by Michael Catanzaro on 2019-06-24 07:03:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2019-06-24 07:03:42 PDT

Size: 2.67 KB

patch

obsolete

>Subversion Revision: 246731
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2da96e0bcdc8d79d0d552b47ba05e9ce507c26f1..168fecde1c215cf532cedd1160a5fdde297950fa 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        Add user agent quirk for bankofamerica.com
>+        https://bugs.webkit.org/show_bug.cgi?id=199154
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This suppresses an unsupported browser warning.
>+
>+        * platform/UserAgentQuirks.cpp:
>+        (WebCore::urlRequiresMacintoshPlatform):
>+
> 2019-06-24  Charlie Turner  <cturner@igalia.com>
> 
>         [GStreamer][MSE] Pausing video sometimes causes skip to finish
>diff --git a/Source/WebCore/platform/UserAgentQuirks.cpp b/Source/WebCore/platform/UserAgentQuirks.cpp
>index f17600f381fdeba2bbe7796fff2fb9738fa2106d..920ddd1e1cdfab93d5fa934627967f214ea4e5ea 100644
>--- a/Source/WebCore/platform/UserAgentQuirks.cpp
>+++ b/Source/WebCore/platform/UserAgentQuirks.cpp
>@@ -109,6 +109,11 @@ static bool urlRequiresMacintoshPlatform(const URL& url)
>     if (domain == "docs.google.com")
>         return true;
> 
>+    // Bank of America shows an unsupported browser warning with WebKitGTK+'s
>+    // standard user agent.
>+    if (baseDomain == "bankofamerica.com")
>+        return true;
>+
>     return false;
> }
> 
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 9b1f60b6ab2eeceb791058a8a3d7526bb057d8a3..a1dc2a46fdcf4252098b4adfbc2fdca8340481b9 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        Add user agent quirk for bankofamerica.com
>+        https://bugs.webkit.org/show_bug.cgi?id=199154
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
>+        (TestWebKitAPI::TEST):
>+
> 2019-06-22  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Expand tests coverage (328 new tests -> 2652).
>diff --git a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>index 5dba246393af906d1cbff68fb2cb524e063b023b..540fc457b8ccab3cfa7055dbbcd00895076bd9f4 100644
>--- a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>@@ -97,6 +97,7 @@ TEST(UserAgentTest, Quirks)
>     assertUserAgentForURLHasMacPlatformQuirk("http://outlook.live.com/");
>     assertUserAgentForURLHasMacPlatformQuirk("http://mail.ntu.edu.tw/");
>     assertUserAgentForURLHasMacPlatformQuirk("http://exchange.tu-berlin.de/");
>+    assertUserAgentForURLHasMacPlatformQuirk("http://bankofamerica.com/");
> }
> 
> } // namespace TestWebKitAPI

Flags:

cgarcia: review+
mcatanzaro: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 199154: 372753 | 372797