Attachment 372752 Details for Bug 199153 – Patch

[patch] Patch

bug-199153-20190624085556.patch (text/plain), 3.40 KB, created by Michael Catanzaro on 2019-06-24 06:55:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2019-06-24 06:55:57 PDT

Size: 3.40 KB

patch

obsolete

>Subversion Revision: 246731
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2da96e0bcdc8d79d0d552b47ba05e9ce507c26f1..10ce41f70bc4eadfc087afaf4890db96f7be5cda 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        Add user agent quirk for Google Drive
>+        https://bugs.webkit.org/show_bug.cgi?id=199153
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This suppresses an unsupported browser warning.
>+
>+        * platform/UserAgentQuirks.cpp:
>+        (WebCore::urlRequiresMacintoshPlatform):
>+        (WebCore::urlRequiresLinuxDesktopPlatform):
>+
> 2019-06-24  Charlie Turner  <cturner@igalia.com>
> 
>         [GStreamer][MSE] Pausing video sometimes causes skip to finish
>diff --git a/Source/WebCore/platform/UserAgentQuirks.cpp b/Source/WebCore/platform/UserAgentQuirks.cpp
>index f17600f381fdeba2bbe7796fff2fb9738fa2106d..d6676bbae48287ad437f6ed7a2c40dd090999398 100644
>--- a/Source/WebCore/platform/UserAgentQuirks.cpp
>+++ b/Source/WebCore/platform/UserAgentQuirks.cpp
>@@ -106,7 +106,8 @@ static bool urlRequiresMacintoshPlatform(const URL& url)
> 
>     // Google Docs shows a scary unsupported browser warning with WebKitGTK+'s
>     // standard user agent.
>-    if (domain == "docs.google.com")
>+    if (domain == "docs.google.com"
>+        || domain == "drive.google.com")
>         return true;
> 
>     return false;
>@@ -114,8 +115,10 @@ static bool urlRequiresMacintoshPlatform(const URL& url)
> 
> static bool urlRequiresLinuxDesktopPlatform(const URL& url)
> {
>-    // docs.google.com requires the macOS platform quirk.
>-    return isGoogle(url) && url.host() != "docs.google.com";
>+    // docs.google.com and drive.google.com require the macOS platform quirk.
>+    return isGoogle(url)
>+        && url.host() != "docs.google.com"
>+        && url.host() != "drive.google.com";
> }
> 
> UserAgentQuirks UserAgentQuirks::quirksForURL(const URL& url)
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 9b1f60b6ab2eeceb791058a8a3d7526bb057d8a3..bb18f65991513b7e12e153e4c60db6cbcbb1d785 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        Add user agent quirk for Google Drive
>+        https://bugs.webkit.org/show_bug.cgi?id=199153
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
>+        (TestWebKitAPI::TEST):
>+
> 2019-06-22  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Expand tests coverage (328 new tests -> 2652).
>diff --git a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>index 5dba246393af906d1cbff68fb2cb524e063b023b..bac8ed11d0a872ff5d82750de6a5a0b02f0dd7f7 100644
>--- a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>@@ -93,6 +93,7 @@ TEST(UserAgentTest, Quirks)
>     assertUserAgentForURLHasMacPlatformQuirk("http://web.whatsapp.com/");
>     assertUserAgentForURLHasMacPlatformQuirk("http://www.chase.com/");
>     assertUserAgentForURLHasMacPlatformQuirk("http://docs.google.com/");
>+    assertUserAgentForURLHasMacPlatformQuirk("http://drive.google.com/");
>     assertUserAgentForURLHasMacPlatformQuirk("http://paypal.com/");
>     assertUserAgentForURLHasMacPlatformQuirk("http://outlook.live.com/");
>     assertUserAgentForURLHasMacPlatformQuirk("http://mail.ntu.edu.tw/");

Flags:

cgarcia: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 199153: 372752