Attachment 372733 Details for Bug 198186 – WIP

[patch] WIP

bug-198186-20190623233251.patch (text/plain), 24.02 KB, created by Myles C. Maxfield on 2019-06-23 23:32:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Myles C. Maxfield

Created: 2019-06-23 23:32:52 PDT

Size: 24.02 KB

patch

obsolete

>Subversion Revision: 246724
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 94ec8a3a5e244c03bee9b326e46c720505267593..df2a7b5748f2df1a49b3191e16e71262037a1090 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,34 @@
>+2019-06-23  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [WHLSL] Standard library is too big to directly include in WebCore
>+        https://bugs.webkit.org/show_bug.cgi?id=198186
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * DerivedSources.make:
>+        * Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h:
>+        (WebCore::WHLSL::AST::CallExpression::setOverloads):
>+        (WebCore::WHLSL::AST::CallExpression::function):
>+        (WebCore::WHLSL::AST::CallExpression::setFunction):
>+        * Modules/webgpu/WHLSL/Cocoa/WHLSLStandardLibraryUtilities.cpp: Added.
>+        (WebCore::WHLSL::decompressStandardLibrary):
>+        (WebCore::WHLSL::decompressAndDecodeStandardLibrary):
>+        (WebCore::WHLSL::cachedStandardLibrary):
>+        * Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:
>+        (WebCore::WHLSL::Metal::FunctionDefinitionWriter::visit):
>+        (WebCore::WHLSL::Metal::metalFunctions):
>+        * Modules/webgpu/WHLSL/WHLSLChecker.cpp:
>+        (WebCore::WHLSL::Checker::visit):
>+        * Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLPrepare.cpp:
>+        (WebCore::WHLSL::prepareShared):
>+        * Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp.
>+        * SourcesCocoa.txt:
>+        * WebCore.xcodeproj/project.pbxproj:
>+
> 2019-06-23  Simon Fraser  <simon.fraser@apple.com>
> 
>         Add OverflowScrollProxyNodes to the scrolling tree
>diff --git a/Source/WebCore/DerivedSources.make b/Source/WebCore/DerivedSources.make
>index d88aed458f0ef6eae31478e1e8b8071fceed91df..63fa82219e69f30586d11befcd702e8ba9a025fe 100644
>--- a/Source/WebCore/DerivedSources.make
>+++ b/Source/WebCore/DerivedSources.make
>@@ -1639,7 +1639,7 @@ $(GENERATE_SETTINGS_PATTERNS) : $(WebCore)/Scripts/GenerateSettings.rb $(GENERAT
> all : WHLSLStandardLibrary.h
> 
> WHLSLStandardLibrary.h : $(JavaScriptCore_SCRIPTS_DIR)/xxd.pl $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
>-	$(PERL) $< WHLSLStandardLibrary $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt $@
>+	bash -c "$(PERL) $< WHLSLStandardLibrary <(gzip -cn $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt) $@"
> 
> # --------
> 
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h
>index 1a0d0274e4d3c72ed2f6c0c8ab1de194d5fe544c..17b94cdca071ce9a042970df7986399494855755 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h
>@@ -71,15 +71,19 @@ public:
>     Optional<Vector<std::reference_wrapper<FunctionDeclaration>, 1>>& overloads() { return m_overloads; }
>     void setOverloads(const Vector<std::reference_wrapper<FunctionDeclaration>, 1>& overloads)
>     {
>-        assert(!hasOverloads());
>+        ASSERT(!hasOverloads());
>         m_overloads = overloads;
>     }
> 
>-    FunctionDeclaration* function() { return m_function; }
>+    FunctionDeclaration& function()
>+    {
>+        ASSERT(m_function);
>+        return *m_function;
>+    }
> 
>     void setFunction(FunctionDeclaration& functionDeclaration)
>     {
>-        assert(!m_function);
>+        ASSERT(!m_function);
>         m_function = &functionDeclaration;
>     }
> 
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/Cocoa/WHLSLStandardLibraryUtilities.cpp b/Source/WebCore/Modules/webgpu/WHLSL/Cocoa/WHLSLStandardLibraryUtilities.cpp
>new file mode 100644
>index 0000000000000000000000000000000000000000..71f79df9205606bad08bb0cc62da54c4c4222602
>--- /dev/null
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/Cocoa/WHLSLStandardLibraryUtilities.cpp
>@@ -0,0 +1,107 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#include "config.h"
>+#include "WHLSLStandardLibraryUtilities.h"
>+
>+#if ENABLE(WEBGPU)
>+
>+#include "WHLSLStandardLibrary.h"
>+#include <compression.h>
>+#include <wtf/NeverDestroyed.h>
>+
>+namespace WebCore {
>+
>+namespace WHLSL {
>+
>+static Vector<LChar> decompressStandardLibrary()
>+{
>+    Vector<LChar> result;
>+
>+    // Parse the gzip header.
>+    auto checks = [&]() {
>+        return sizeof(WHLSLStandardLibrary) >= 10 && WHLSLStandardLibrary[0] == 0x1f && WHLSLStandardLibrary[1] == 0x8b && WHLSLStandardLibrary[2] == 0x8 && WHLSLStandardLibrary[3] == 0x0;
>+    };
>+    ASSERT(checks());
>+    if (!checks())
>+        return { };
>+
>+    constexpr auto ignoredByteCount = 10;
>+
>+    compression_stream stream;
>+    auto status = compression_stream_init(&stream, COMPRESSION_STREAM_DECODE, COMPRESSION_ZLIB);
>+    ASSERT(status == COMPRESSION_STATUS_OK);
>+    if (status != COMPRESSION_STATUS_OK)
>+        return { };
>+    stream.dst_ptr = result.data();
>+    stream.dst_size = result.size();
>+    stream.src_ptr = WHLSLStandardLibrary + ignoredByteCount;
>+    stream.src_size = sizeof(WHLSLStandardLibrary) - ignoredByteCount;
>+
>+    do {
>+        status = compression_stream_process(&stream, COMPRESSION_STREAM_FINALIZE);
>+        auto currentDestinationSize = result.size();
>+        switch (status) {
>+        case COMPRESSION_STATUS_OK: {
>+            auto newSize = result.size() * 1.5 + 1;
>+            result.grow(newSize);
>+            stream.dst_ptr = result.data() + currentDestinationSize;
>+            stream.dst_size = result.size() - currentDestinationSize;
>+            break;
>+        }
>+        case COMPRESSION_STATUS_END:
>+            status = compression_stream_destroy(&stream);
>+            ASSERT(status == COMPRESSION_STATUS_OK);
>+            if (status == COMPRESSION_STATUS_OK) {
>+                result.shrink(stream.dst_ptr - result.data());
>+                return result;
>+            }
>+            return { };
>+        case COMPRESSION_STATUS_ERROR:
>+        default:
>+            ASSERT_NOT_REACHED();
>+            compression_stream_destroy(&stream);
>+            return { };
>+        }
>+    } while (true);
>+}
>+
>+static String decompressAndDecodeStandardLibrary()
>+{
>+    auto decompressedStandardLibrary = decompressStandardLibrary();
>+    return String::fromUTF8(decompressedStandardLibrary.data(), decompressedStandardLibrary.size());
>+}
>+
>+const String& cachedStandardLibrary()
>+{
>+    static NeverDestroyed<String> standardLibrary(decompressAndDecodeStandardLibrary());
>+    return standardLibrary.get();
>+}
>+
>+}
>+
>+}
>+
>+#endif
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp b/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp
>index e4f801e2ef375386246deedf138a7e609c99426e..749bdf947c723eb354339ff73e74e1b633f7abdb 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp
>@@ -35,6 +35,7 @@
> #include "WHLSLTypeNamer.h"
> #include "WHLSLVisitor.h"
> #include <wtf/HashMap.h>
>+#include <wtf/HashSet.h>
> #include <wtf/SetForScope.h>
> #include <wtf/text/StringBuilder.h>
> 
>@@ -554,8 +555,7 @@ void FunctionDefinitionWriter::visit(AST::CallExpression& callExpression)
>         checkErrorAndVisit(argument);
>         argumentNames.append(takeLastValue());
>     }
>-    ASSERT(callExpression.function());
>-    auto iterator = m_functionMapping.find(callExpression.function());
>+    auto iterator = m_functionMapping.find(&callExpression.function());
>     ASSERT(iterator != m_functionMapping.end());
>     auto variableName = generateNextVariableName();
>     if (!matches(callExpression.resolvedType(), m_intrinsics.voidType()))
>@@ -787,6 +787,26 @@ static SharedMetalFunctionsResult sharedMetalFunctions(Program& program, TypeNam
>     return { WTFMove(functionMapping), stringBuilder.toString() };
> }
> 
>+class ReachableFunctionsGatherer : public Visitor {
>+public:
>+    void visit(AST::FunctionDeclaration& functionDeclaration) override
>+    {
>+        Visitor::visit(functionDeclaration);
>+        m_reachableFunctions.add(&functionDeclaration);
>+    }
>+
>+    void visit(AST::CallExpression& callExpression) override
>+    {
>+        Visitor::visit(callExpression);
>+        checkErrorAndVisit(callExpression.function());
>+    }
>+
>+    HashSet<AST::FunctionDeclaration*> takeReachableFunctions() { return WTFMove(m_reachableFunctions); }
>+
>+private:
>+    HashSet<AST::FunctionDeclaration*> m_reachableFunctions;
>+};
>+
> RenderMetalFunctions metalFunctions(Program& program, TypeNamer& typeNamer, MatchedRenderSemantics&& matchedSemantics, Layout& layout)
> {
>     auto sharedMetalFunctions = Metal::sharedMetalFunctions(program, typeNamer);
>@@ -794,20 +814,29 @@ RenderMetalFunctions metalFunctions(Program& program, TypeNamer& typeNamer, Matc
>     StringBuilder stringBuilder;
>     stringBuilder.append(sharedMetalFunctions.metalFunctions);
> 
>-    auto* vertexShaderEntryPoint = matchedSemantics.vertexShader;
>-    auto* fragmentShaderEntryPoint = matchedSemantics.fragmentShader;
>+    auto& vertexShaderEntryPoint = *matchedSemantics.vertexShader;
>+    auto& fragmentShaderEntryPoint = *matchedSemantics.fragmentShader;
>+
>+    ReachableFunctionsGatherer reachableFunctionsGatherer;
>+    reachableFunctionsGatherer.visit(vertexShaderEntryPoint);
>+    reachableFunctionsGatherer.visit(fragmentShaderEntryPoint);
>+    auto reachableFunctions = reachableFunctionsGatherer.takeReachableFunctions;
> 
>     RenderFunctionDefinitionWriter functionDefinitionWriter(program.intrinsics(), typeNamer, sharedMetalFunctions.functionMapping, WTFMove(matchedSemantics), layout);
>-    for (auto& nativeFunctionDeclaration : program.nativeFunctionDeclarations())
>-        functionDefinitionWriter.visit(nativeFunctionDeclaration);
>-    for (auto& functionDefinition : program.functionDefinitions())
>-        functionDefinitionWriter.visit(functionDefinition);
>+    for (auto& nativeFunctionDeclaration : program.nativeFunctionDeclarations()) {
>+        if (reachableFunctions.contains(&nativeFunctionDeclaration))
>+            functionDefinitionWriter.visit(nativeFunctionDeclaration);
>+    }
>+    for (auto& functionDefinition : program.functionDefinitions()) {
>+        if (reachableFunctions.contains(&functionDefinition))
>+            functionDefinitionWriter.visit(functionDefinition);
>+    }
>     stringBuilder.append(functionDefinitionWriter.toString());
> 
>     RenderMetalFunctions result;
>     result.metalSource = stringBuilder.toString();
>-    result.mangledVertexEntryPointName = sharedMetalFunctions.functionMapping.get(vertexShaderEntryPoint);
>-    result.mangledFragmentEntryPointName = sharedMetalFunctions.functionMapping.get(fragmentShaderEntryPoint);
>+    result.mangledVertexEntryPointName = sharedMetalFunctions.functionMapping.get(&vertexShaderEntryPoint);
>+    result.mangledFragmentEntryPointName = sharedMetalFunctions.functionMapping.get(&fragmentShaderEntryPoint);
>     return result;
> }
> 
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp
>index 6b2bb04ab7a73ffd4d7c7958fe7bd1424aac8cea..38d0ac0a373d2fdf87299385990dc3304ffd0be7 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp
>@@ -1139,7 +1139,6 @@ void Checker::visit(AST::VariableReference& variableReference)
> 
> void Checker::visit(AST::Return& returnStatement)
> {
>-    ASSERT(returnStatement.function());
>     if (returnStatement.value()) {
>         auto valueInfo = recurseAndGetInfo(*returnStatement.value());
>         if (!valueInfo)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp
>index f4ce762dd6c32e1014d779a12357a454efe68066..4322a69c9a78abb495beee21ce0e3e3e9a877903 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp
>@@ -49,17 +49,15 @@ public:
> public:
>     void visit(AST::CallExpression& callExpression) override
>     {
>-        ASSERT(callExpression.function());
>-        if ((callExpression.function() == &m_intrinsics.ddx() || callExpression.function() == &m_intrinsics.ddy()) && m_entryPointType != AST::EntryPointType::Fragment) {
>+        if ((&callExpression.function() == &m_intrinsics.ddx() || &callExpression.function() == &m_intrinsics.ddy()) && m_entryPointType != AST::EntryPointType::Fragment) {
>             setError();
>             return;
>         }
>-        if ((callExpression.function() == &m_intrinsics.allMemoryBarrier() || callExpression.function() == &m_intrinsics.deviceMemoryBarrier() || callExpression.function() == &m_intrinsics.groupMemoryBarrier())
>+        if ((&callExpression.function() == &m_intrinsics.allMemoryBarrier() || &callExpression.function() == &m_intrinsics.deviceMemoryBarrier() || &callExpression.function() == &m_intrinsics.groupMemoryBarrier())
>             && m_entryPointType != AST::EntryPointType::Compute) {
>             setError();
>             return;
>         }
>-        ASSERT(callExpression.function());
>         Visitor::visit(*callExpression.function());
>     }
> 
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp
>index ed9930b6993b64a528806897fc9b821ba4a7ad95..d78be53fc6c169e5bf989fc041cfba6f309b6152 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp
>@@ -46,7 +46,7 @@
> #include "WHLSLRecursionChecker.h"
> #include "WHLSLRecursiveTypeChecker.h"
> #include "WHLSLSemanticMatcher.h"
>-#include "WHLSLStandardLibrary.h"
>+#include "WHLSLStandardLibraryUtilities.h"
> #include "WHLSLStatementBehaviorChecker.h"
> #include "WHLSLSynthesizeArrayOperatorLength.h"
> #include "WHLSLSynthesizeConstructors.h"
>@@ -110,8 +110,7 @@ static Optional<Program> prepareShared(String& whlslSource)
> {
>     Program program;
>     Parser parser;
>-    auto standardLibrary = String::fromUTF8(WHLSLStandardLibrary, sizeof(WHLSLStandardLibrary));
>-    auto parseStdLibFailure = parser.parse(program, standardLibrary, Parser::Mode::StandardLibrary);
>+    auto parseStdLibFailure = parser.parse(program, cachedStandardLibrary(), Parser::Mode::StandardLibrary);
>     if (!ASSERT_DISABLED && parseStdLibFailure) {
>         dataLogLn("failed to parse the standard library: ", *parseStdLibFailure);
>         RELEASE_ASSERT_NOT_REACHED();
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp
>index 43cf9cbd5215b8bfb0db770063aff68aecb80eb9..cd0800d36192e48fc537723aa80a0ea9f632c5f6 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp
>@@ -56,8 +56,7 @@ private:
> 
>     void visit(AST::CallExpression& callExpression) override
>     {
>-        ASSERT(callExpression.function());
>-        Visitor::visit(*callExpression.function());
>+        Visitor::visit(callExpression.function());
>     }
> 
>     HashSet<AST::FunctionDefinition*> m_visitingSet;
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.h b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.h
>new file mode 100644
>index 0000000000000000000000000000000000000000..cddf5481a11f8448385a35d3b1002fd89f5209a1
>--- /dev/null
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.h
>@@ -0,0 +1,42 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#pragma once
>+
>+#if ENABLE(WEBGPU)
>+
>+#include <wtf/text/WTFString.h>
>+
>+namespace WebCore {
>+
>+namespace WHLSL {
>+
>+const String& cachedStandardLibrary();
>+
>+}
>+
>+}
>+
>+#endif
>diff --git a/Source/WebCore/SourcesCocoa.txt b/Source/WebCore/SourcesCocoa.txt
>index 7b1e575eab12d8155d46fee14b151381e3959014..13fbd10d7236f246f2682cf17e0f9d380330aaea 100644
>--- a/Source/WebCore/SourcesCocoa.txt
>+++ b/Source/WebCore/SourcesCocoa.txt
>@@ -27,6 +27,8 @@ Modules/plugins/QuickTimePluginReplacement.mm
> Modules/plugins/YouTubePluginReplacement.cpp
> Modules/webdatabase/cocoa/DatabaseManagerCocoa.mm
> 
>+Modules/webgpu/WHLSL/Cocoa/WHLSLStandardLibraryUtilities.cpp
>+
> accessibility/ios/AccessibilityObjectIOS.mm
> accessibility/ios/AXObjectCacheIOS.mm
> accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
>diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>index da288703ba746788e0a229af50db5a3e716274c3..305d78d1da8c271f177ef16aa92586d6869d7c9f 100644
>--- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>+++ b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>@@ -629,6 +629,7 @@
> 		1C73A71521857587004CCEA5 /* TextDecorationThickness.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CB6B4F8217B83930093B9CD /* TextDecorationThickness.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		1C81B95A0E97330800266E07 /* InspectorController.h in Headers */ = {isa = PBXBuildFile; fileRef = 1C81B9560E97330800266E07 /* InspectorController.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		1C81B95C0E97330800266E07 /* InspectorClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 1C81B9580E97330800266E07 /* InspectorClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
>+		1C8D26D122C09E8300D125F3 /* libcompression.tbd in Frameworks */ = {isa = PBXBuildFile; fileRef = 1C8D26D022C09CDE00D125F3 /* libcompression.tbd */; };
> 		1CA19E160DC255CA0065A994 /* EventLoop.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CA19E150DC255CA0065A994 /* EventLoop.h */; };
> 		1CAF34810A6C405200ABE06E /* WebScriptObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CAF347E0A6C405200ABE06E /* WebScriptObject.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		1CAF34820A6C405200ABE06E /* WebScriptObject.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1CAF347F0A6C405200ABE06E /* WebScriptObject.mm */; };
>@@ -6412,6 +6413,9 @@
> 		1C86CA4C22AA19FF001BF961 /* WHLSLComputeDimensions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLComputeDimensions.h; sourceTree = "<group>"; };
> 		1C86CA4E22AA23C9001BF961 /* GPUPipelineMetalConvertLayout.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = GPUPipelineMetalConvertLayout.cpp; sourceTree = "<group>"; };
> 		1C86CA4F22AA23C9001BF961 /* GPUPipelineMetalConvertLayout.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GPUPipelineMetalConvertLayout.h; sourceTree = "<group>"; };
>+		1C8D26C922C0945300D125F3 /* WHLSLStandardLibraryUtilities.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLStandardLibraryUtilities.h; sourceTree = "<group>"; };
>+		1C8D26CE22C0951300D125F3 /* WHLSLStandardLibraryUtilities.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WHLSLStandardLibraryUtilities.cpp; sourceTree = "<group>"; };
>+		1C8D26D022C09CDE00D125F3 /* libcompression.tbd */ = {isa = PBXFileReference; lastKnownFileType = "sourcecode.text-based-dylib-definition"; name = libcompression.tbd; path = usr/lib/libcompression.tbd; sourceTree = SDKROOT; };
> 		1C904DF90BA9D2C80081E9D0 /* Version.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = Version.xcconfig; sourceTree = "<group>"; };
> 		1C9AE5CA21ED9DF50069D5F2 /* WHLSLHighZombieFinder.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WHLSLHighZombieFinder.cpp; sourceTree = "<group>"; };
> 		1C9AE5CB21ED9DF50069D5F2 /* WHLSLHighZombieFinder.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLHighZombieFinder.h; sourceTree = "<group>"; };
>@@ -15592,6 +15596,7 @@
> 				FD2DBF1312B048A300ED98C6 /* AudioToolbox.framework in Frameworks */,
> 				1AB33DA512551E320024457A /* IOKit.framework in Frameworks */,
> 				93F19B1608245E59001E9ABC /* JavaScriptCore.framework in Frameworks */,
>+				1C8D26D122C09E8300D125F3 /* libcompression.tbd in Frameworks */,
> 				93F19B1708245E59001E9ABC /* libicucore.dylib in Frameworks */,
> 				1CFAE3230A6D6A3F0032593D /* libobjc.dylib in Frameworks */,
> 				1C09D0591E31C6A900725F18 /* libPAL.a in Frameworks */,
>@@ -16185,6 +16190,7 @@
> 				A15E6BF01E212A6A0080AF34 /* Foundation.framework */,
> 				1AB33DA412551E320024457A /* IOKit.framework */,
> 				F8216299029F4FB501000131 /* JavaScriptCore.framework */,
>+				1C8D26D022C09CDE00D125F3 /* libcompression.tbd */,
> 				93F1D31A0558CC5C00821BC0 /* libicucore.dylib */,
> 				1CFAE3220A6D6A3F0032593D /* libobjc.dylib */,
> 				DD763BB10992C2C900740B8E /* libxml2.dylib */,
>@@ -17073,6 +17079,14 @@
> 			tabWidth = 8;
> 			usesTabs = 0;
> 		};
>+		1C8D26CD22C0948F00D125F3 /* Cocoa */ = {
>+			isa = PBXGroup;
>+			children = (
>+				1C8D26CE22C0951300D125F3 /* WHLSLStandardLibraryUtilities.cpp */,
>+			);
>+			path = Cocoa;
>+			sourceTree = "<group>";
>+		};
> 		1CA0C2F621EEDAD200A11860 /* AST */ = {
> 			isa = PBXGroup;
> 			children = (
>@@ -25485,6 +25499,7 @@
> 			isa = PBXGroup;
> 			children = (
> 				1CA0C2F621EEDAD200A11860 /* AST */,
>+				1C8D26CD22C0948F00D125F3 /* Cocoa */,
> 				1CECB3AD21F2B96400F44542 /* Metal */,
> 				C20F88AA22966B0E00D610FA /* WHLSLASTDumper.cpp */,
> 				C20F88AC22966B0F00D610FA /* WHLSLASTDumper.h */,
>@@ -25537,6 +25552,7 @@
> 				C24A57B221FB8DDA004C6DD1 /* WHLSLSemanticMatcher.cpp */,
> 				C24A57B321FB8DDA004C6DD1 /* WHLSLSemanticMatcher.h */,
> 				C21BF74521CD969800227979 /* WHLSLStandardLibrary.txt */,
>+				1C8D26C922C0945300D125F3 /* WHLSLStandardLibraryUtilities.h */,
> 				1CECB3A921F2B67300F44542 /* WHLSLStatementBehaviorChecker.cpp */,
> 				1CECB3A821F2B67300F44542 /* WHLSLStatementBehaviorChecker.h */,
> 				C234A9A921E92C17003C984D /* WHLSLSynthesizeArrayOperatorLength.cpp */,

Actions: View | Formatted Diff | Diff

Attachments on bug 198186: 372733 | 372942 | 372998 | 373090 | 373143 | 373164 | 373181 | 373187 | 373188 | 373189 | 373212 | 373343 | 373392