Attachment 372695 Details for Bug 198999 – Patch

[patch] Patch

bug-198999-20190623163255.patch (text/plain), 2.13 KB, created by Antoine Quint on 2019-06-23 07:32:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antoine Quint

Created: 2019-06-23 07:32:56 PDT

Size: 2.13 KB

patch

obsolete

>Subversion Revision: 246716
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 896352d97a36513326afe02ec1d036cdf5092dc4..db1ec4cc4a26a3b76c29c260593e6ed509bcf7ca 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-23  Antoine Quint  <graouts@apple.com>
>+
>+        [Pointer Events] Respect pointer capture when dispatching mouse boundary events and updating :hover
>+        https://bugs.webkit.org/show_bug.cgi?id=198999
>+        <rdar://problem/52005663>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We should only set the mouse events capturing element in EventHandler if we're dealing with mouse-originated Pointer Events (part 2).
>+
>+        * page/PointerCaptureController.cpp:
>+        (WebCore::PointerCaptureController::releasePointerCapture):
>+
> 2019-06-22  Antoine Quint  <graouts@apple.com>
> 
>         [Pointer Events] Respect pointer capture when dispatching mouse boundary events and updating :hover
>diff --git a/Source/WebCore/page/PointerCaptureController.cpp b/Source/WebCore/page/PointerCaptureController.cpp
>index 40537c4a699afbaa8f2c444e08d7bd5b7b523639..99353e38616694666b6b662a9bf955f1d9bf422b 100644
>--- a/Source/WebCore/page/PointerCaptureController.cpp
>+++ b/Source/WebCore/page/PointerCaptureController.cpp
>@@ -104,12 +104,14 @@ ExceptionOr<void> PointerCaptureController::releasePointerCapture(Element* captu
>         return { };
> 
>     // 3. For the specified pointerId, clear the pending pointer capture target override, if set.
>-    iterator->value.pendingTargetOverride = nullptr;
>+    auto& capturingData = iterator->value;
>+    capturingData.pendingTargetOverride = nullptr;
> 
>     // Since we may not call processPendingPointerCapture() until the dispatch of the next event,
>     // we must reset EventHandler's capturing mouse element right now so that the next event processed
>     // does not use it as an overriding target.
>-    m_page.mainFrame().eventHandler().setCapturingMouseEventsElement(nullptr);
>+    if (capturingData.pointerType == PointerEvent::mousePointerType())
>+        m_page.mainFrame().eventHandler().setCapturingMouseEventsElement(nullptr);
> 
>     return { };
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 198999: 372461 | 372463 | 372468 | 372472 | 372481 | 372551 | 372685 | 372695 | 372919 | 372923 | 372924 | 372931 | 372955