WebKit Bugzilla
Attachment 372691 Details for
Bug 199131
: Web Inspector: Styles: show green highlight for newly added properties only when name and value are present
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
patch.txt (text/plain), 1.48 KB, created by
Nikita Vasilyev
on 2019-06-22 16:00:48 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Nikita Vasilyev
Created:
2019-06-22 16:00:48 PDT
Size:
1.48 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 171555d220c..b9626b76450 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,13 @@ >+2019-06-22 Nikita Vasilyev <nvasilyev@apple.com> >+ >+ Web Inspector: Styles: show green highlight for newly added properties only when name and value are present >+ https://bugs.webkit.org/show_bug.cgi?id=199131 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UserInterface/Views/SpreadsheetStyleProperty.js: >+ (WI.SpreadsheetStyleProperty.prototype.updateStatus): >+ > 2019-06-22 Nikita Vasilyev <nvasilyev@apple.com> > > REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last property no longer focuses on selector on next rule >diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js >index 7f593231a28..7f169e9c4ed 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js >+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js >@@ -313,7 +313,7 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object > if (!this._property.enabled) > classNames.push("disabled"); > >- if (this._property.modified) >+ if (this._property.modified && this._property.name && this._property.rawValue) > classNames.push("modified"); > > if (this._selected)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199131
: 372691