Attachment 372690 Details for Bug 199130 – Patch

[patch] Patch

patch.txt (text/plain), 2.31 KB, created by Nikita Vasilyev on 2019-06-22 15:38:51 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-06-22 15:38:51 PDT

Size: 2.31 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 171555d220c..430787940ec 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-06-22  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Styles: unbalanced quotes and parenthesis aren't displayed as property closed after editing values
>+        https://bugs.webkit.org/show_bug.cgi?id=199090
>+        <rdar://problem/51965431>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        `}` gets added by WI.tokenizeCSSValue (CodeMirror CSS tokenizer) when it encounters unbalanced quotes.
>+        Fix unbalanced quotes by rendering the value from the model, not the view.
>+
>+        * UserInterface/Views/SpreadsheetStyleProperty.js:
>+        (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidCommit):
>+        For consistency, render property name from the model as well.
>+
> 2019-06-22  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last property no longer focuses on selector on next rule
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>index 7f593231a28..926bb0a1fb1 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>@@ -359,16 +359,14 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
> 
>     spreadsheetTextFieldDidCommit(textField, {direction})
>     {
>-        let propertyName = this._nameTextField.value.trim();
>-        let propertyValue = this._valueTextField.value.trim();
>         let willRemoveProperty = false;
>         let isEditingName = textField === this._nameTextField;
> 
>-        if (!propertyName || (!propertyValue && !isEditingName && direction === "forward"))
>+        if (!this._property.name || (!this._property.rawValue && !isEditingName && direction === "forward"))
>             willRemoveProperty = true;
> 
>         if (!isEditingName && !willRemoveProperty)
>-            this._renderValue(propertyValue);
>+            this._renderValue(this._property.rawValue);
> 
>         if (direction === "forward") {
>             if (isEditingName && !willRemoveProperty) {

Flags:

hi: review+
hi: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 199130: 372690 | 373589