Attachment 372686 Details for Bug 199128 – Patch

[patch] Patch

bug-199128-20190622132627.patch (text/plain), 2.31 KB, created by Matt Baker on 2019-06-22 13:26:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2019-06-22 13:26:27 PDT

Size: 2.31 KB

patch

obsolete

>Subversion Revision: 246711
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index bf69d8096dbbe45b503e04e4cba25dabb7e8c483..7297d1d34155dad4755f149166d4a4a2ab2d4e01 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-22  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: Elements: show shadow DOM by default
>+        https://bugs.webkit.org/show_bug.cgi?id=199128
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Base/Setting.js:
>+
>+        * UserInterface/Test/Test.js:
>+        (WI.loaded):
>+        Overriding the default value isn't necessary since the default is now true.
>+
> 2019-06-21  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: remove unused DataGrid style .force-focus
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Setting.js b/Source/WebInspectorUI/UserInterface/Base/Setting.js
>index bfa983806359e22083863b7fe6dc0e6fde2a50d3..d877dd387b09b925025683b93d7a1c0bc464be67 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Setting.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Setting.js
>@@ -168,7 +168,7 @@ WI.settings = {
>     showRulers: new WI.Setting("show-rulers", false),
>     showRulersDuringElementSelection: new WI.Setting("show-rulers-during-element-selection", true),
>     showScopeChainOnPause: new WI.Setting("show-scope-chain-sidebar", true),
>-    showShadowDOM: new WI.Setting("show-shadow-dom", false),
>+    showShadowDOM: new WI.Setting("show-shadow-dom", true),
>     showWhitespaceCharacters: new WI.Setting("show-whitespace-characters", false),
>     tabSize: new WI.Setting("tab-size", 4),
>     timelinesAutoStop: new WI.Setting("timelines-auto-stop", true),
>diff --git a/Source/WebInspectorUI/UserInterface/Test/Test.js b/Source/WebInspectorUI/UserInterface/Test/Test.js
>index 73ac3d317c8f45eb51e488392588c0ced20c397c..5054f4d0230db97f1deac883d03aa197a2fefbb3 100644
>--- a/Source/WebInspectorUI/UserInterface/Test/Test.js
>+++ b/Source/WebInspectorUI/UserInterface/Test/Test.js
>@@ -69,9 +69,6 @@ WI.loaded = function()
>     // Register for events.
>     document.addEventListener("DOMContentLoaded", WI.contentLoaded);
> 
>-    // Non-default global setting values for tests.
>-    WI.settings.showShadowDOM.value = true;
>-
>     // Targets.
>     WI.backendTarget = null;
>     WI.pageTarget = null;

Actions: View | Formatted Diff | Diff

Attachments on bug 199128: 372686