Attachment 372678 Details for Bug 199127 – Patch

[patch] Patch

bug-199127-20190622060546.patch (text/plain), 2.29 KB, created by zalan on 2019-06-22 06:05:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2019-06-22 06:05:48 PDT

Size: 2.29 KB

patch

obsolete

>Subversion Revision: 246682
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 66f274e65687b8a53afd440be75c2b9a87d3c52d..72e356b68d1490d59ce940b3040f558cd4d748b9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-22  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC][IFC] The anonymous InlineBox wrapper for the text node should take the parent style.
>+        https://bugs.webkit.org/show_bug.cgi?id=199127
>+        <rdar://problem/52017744>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        <span style="vertical-align: bottom">bottom aligned text</span>
>+        The InlineBox wrapper for the "bottom aligned text" content should take the parent span's style.
>+
>+        * layout/layouttree/LayoutTreeBuilder.cpp:
>+        (WebCore::Layout::TreeBuilder::createSubTree):
>+
> 2019-06-21  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         [WHLSL] read modify write expressions do no work as expected
>diff --git a/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp b/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
>index d6f2a3eaba13d1505267973d56cf73a695f6213c..5658fa48488b7a196122265f6970ae4d218b0a62 100644
>--- a/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
>+++ b/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
>@@ -106,7 +106,11 @@ void TreeBuilder::createSubTree(const RenderElement& rootRenderer, Container& ro
>         std::unique_ptr<Box> box;
> 
>         if (is<RenderText>(child)) {
>-            box = std::make_unique<InlineBox>(Optional<Box::ElementAttributes>(), RenderStyle::createAnonymousStyleWithDisplay(rootRenderer.style(), DisplayType::Inline));
>+            // FIXME: Clearly there must be a helper function for this.
>+            if (rootRenderer.style().display() == DisplayType::Inline)
>+                box = std::make_unique<InlineBox>(Optional<Box::ElementAttributes>(), RenderStyle::clone(rootRenderer.style()));
>+            else
>+                box = std::make_unique<InlineBox>(Optional<Box::ElementAttributes>(), RenderStyle::createAnonymousStyleWithDisplay(rootRenderer.style(), DisplayType::Inline));
>             downcast<InlineBox>(*box).setTextContent(downcast<RenderText>(child).originalText());
>         } else if (is<RenderLineBreak>(child)) {
>             auto& renderer = downcast<RenderLineBreak>(child);

Actions: View | Formatted Diff | Diff

Attachments on bug 199127: 372677 | 372678