Attachment 372668 Details for Bug 199125 – Patch

[patch] Patch

patch.txt (text/plain), 1.69 KB, created by Nikita Vasilyev on 2019-06-21 19:13:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-06-21 19:13:48 PDT

Size: 1.69 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index bf69d8096db..e09023839f9 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-21  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last property no longer focuses on selector on next rule
>+        https://bugs.webkit.org/show_bug.cgi?id=199125
>+        <rdar://problem/52011182>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Since SpreadsheetSelectorField's focus handler was removed in r241980, focusing on the selector element
>+        doesn't start editing it.
>+
>+        * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
>+        (WI.SpreadsheetCSSStyleDeclarationSection.prototype.startEditingRuleSelector):
>+
> 2019-06-21  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: remove unused DataGrid style .force-focus
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js
>index fecbe60c23f..60f3931b5fb 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js
>@@ -145,7 +145,7 @@ WI.SpreadsheetCSSStyleDeclarationSection = class SpreadsheetCSSStyleDeclarationS
>         this._shouldFocusSelectorElement = false;
> 
>         if (this._style.selectorEditable)
>-            this._selectorElement.focus();
>+            this._selectorTextField.startEditing();
>         else
>             this._propertiesEditor.startEditingFirstProperty();
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 199125: 372667 | 372668