Attachment 372663 Details for Bug 199090 – Patch

[patch] Patch

patch.txt (text/plain), 1.69 KB, created by Nikita Vasilyev on 2019-06-21 18:19:15 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-06-21 18:19:15 PDT

Size: 1.69 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index bf69d8096db..cc7529060e1 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-21  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Styles: unbalanced quotes and parenthesis aren't displayed as property closed after editing values
>+        https://bugs.webkit.org/show_bug.cgi?id=199090
>+        <rdar://problem/51965431>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SpreadsheetStyleProperty.js:
>+        (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
>+        Unbalanced quotes and parenthesis are fixed inside of CSSProperty's rawValue setter.
>+        Render the value from the model, not the view.
>+
> 2019-06-21  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: remove unused DataGrid style .force-focus
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>index 6cbc629b264..7f593231a28 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>@@ -402,7 +402,7 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
>         }
> 
>         if (textField === this._valueTextField)
>-            this._renderValue(this._valueElement.textContent);
>+            this._renderValue(this._property.rawValue);
> 
>         if (typeof this._delegate.spreadsheetStylePropertyFocusMoved === "function")
>             this._delegate.spreadsheetStylePropertyFocusMoved(this, {direction: null});

Actions: View | Formatted Diff | Diff

Attachments on bug 199090: 372663