Attachment 372659 Details for Bug 199121 – Patch

[patch] Patch

bug-199121-20190621183005.patch (text/plain), 1.87 KB, created by Aakash Jain on 2019-06-21 15:30:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-06-21 15:30:06 PDT

Size: 1.87 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 246700)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-06-21  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] EWS should provide option to download layout test results zip file
>+        https://bugs.webkit.org/show_bug.cgi?id=199121
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
>+        (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
>+
> 2019-06-21  Youenn Fablet  <youenn@apple.com>
> 
>         WebPageProxy should use the right path for sandbox extension
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 246700)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -1090,7 +1090,7 @@ class ExtractTestResults(master.MasterSh
> 
>     descriptionDone = ['Extracted test results']
>     command = ['unzip', zipFile, '-d', resultDirectory]
>-    renderables = ['resultDirectory']
>+    renderables = ['resultDirectory', 'zipFile']
> 
>     def __init__(self):
>         super(ExtractTestResults, self).__init__(self.command)
>@@ -1098,8 +1098,12 @@ class ExtractTestResults(master.MasterSh
>     def resultDirectoryURL(self):
>         return self.resultDirectory.replace('public_html/', '/') + '/'
> 
>+    def resultsDownloadURL(self):
>+        return self.zipFile.replace('public_html/', '/')
>+
>     def addCustomURLs(self):
>         self.addURL('view layout test results', self.resultDirectoryURL() + 'results.html')
>+        self.addURL('download layout test results', self.resultsDownloadURL())
> 
>     def finished(self, result):
>         self.addCustomURLs()

Actions: View | Formatted Diff | Diff

Attachments on bug 199121: 372659