Attachment 372658 Details for Bug 199120 – Patch

[patch] Patch

bug-199120-20190621182315.patch (text/plain), 2.50 KB, created by Aakash Jain on 2019-06-21 15:23:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-06-21 15:23:16 PDT

Size: 2.50 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 246700)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-06-21  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Upload test results after running layout-tests
>+        https://bugs.webkit.org/show_bug.cgi?id=199120
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (RunWebKitTests.evaluateCommand):
>+        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
>+
> 2019-06-21  Youenn Fablet  <youenn@apple.com>
> 
>         WebPageProxy should use the right path for sandbox extension
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 246700)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -789,6 +789,16 @@ class RunWebKitTests(shell.Test):
>             self.setCommand(self.command + additionalArguments)
>         return shell.Test.start(self)
> 
>+    def evaluateCommand(self, cmd):
>+        rc = super(RunWebKitTests, self).evaluateCommand(cmd)
>+        if rc == SUCCESS:
>+            message = 'Passed layout tests'
>+            self.descriptionDone = message
>+            self.build.results = SUCCESS
>+            self.build.buildFinished([message], SUCCESS)
>+        else:
>+            self.build.addStepsAfterCurrentStep([ArchiveTestResults(), UploadTestResults(), ExtractTestResults()])
>+        return rc
> 
> class RunWebKit1Tests(RunWebKitTests):
>     def start(self):
>Index: Tools/BuildSlaveSupport/ews-build/steps_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(revision 246700)
>+++ Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(working copy)
>@@ -816,7 +816,7 @@ class TestRunWebKitTests(BuildStepMixinA
>                         )
>             + 0,
>         )
>-        self.expectOutcome(result=SUCCESS, state_string='layout-tests')
>+        self.expectOutcome(result=SUCCESS, state_string='Passed layout tests')
>         return self.runStep()
> 
>     def test_failure(self):
>@@ -852,7 +852,7 @@ class TestRunWebKit1Tests(BuildStepMixin
>                         )
>             + 0,
>         )
>-        self.expectOutcome(result=SUCCESS, state_string='layout-tests')
>+        self.expectOutcome(result=SUCCESS, state_string='Passed layout tests')
>         return self.runStep()
> 
>     def test_failure(self):

Actions: View | Formatted Diff | Diff

Attachments on bug 199120: 372658