Attachment 372656 Details for Bug 199119 – Patch

[patch] Patch

bug-199119-20190621151206.patch (text/plain), 4.42 KB, created by Brent Fulgham on 2019-06-21 15:12:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2019-06-21 15:12:07 PDT

Size: 4.42 KB

patch

obsolete

>Subversion Revision: 246653
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 4d853a146b7da1afffe23c4f49fd8235215af7b1..54f796b7744800bbd29e892fdc2d5be935c74ccf 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-06-21  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Adjust sandboxes based on seed feedback
>+        https://bugs.webkit.org/show_bug.cgi?id=199119
>+        <rdar://problem/50164879>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Update our sandboxes to address test failures and bugs encountered during initial iOS 13 and
>+        macOS Catalina testing.
>+
>+        * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
>+        * Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
>+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
>+        * WebProcess/com.apple.WebProcess.sb.in:
>+
> 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
> 
>         [GTK] Enable navigation swipe layout tests
>diff --git a/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in b/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
>index 88b8ed6aab63fa5a4b30d4e018f0bce961dc92be..15e02fd8c95487bb9f6c9ac9b024285cc81cde16 100644
>--- a/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
>+++ b/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
>@@ -92,8 +92,10 @@
>         "com.apple.WebFoundation"
>         "com.apple.ist.ds.appleconnect2.uat" ;; Remove after <rdar://problem/35542803> ships
>         "com.apple.networkConnect"))
>+
> (allow file-read*
>     ;; Basic system paths
>+    (subpath "/Library/Fonts") ;; Needed to serialize font data types <rdar://problem/50164879>
>     (subpath "/Library/Frameworks")
>     (subpath "/Library/Managed Preferences")
> 
>diff --git a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb
>index 80716ec64348bfb448ede6762d4c0dd9c19cdf7f..5e7e908f4ef8a63cb4fef4f30e5e2a92e1875883 100644
>--- a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb
>+++ b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb
>@@ -72,6 +72,12 @@
>     (literal "/usr/local/lib/log") ; <rdar://problem/36629495>
> )
> 
>+;; Read-only preferences and data
>+(allow file-read*
>+    ;; Basic system paths
>+    (subpath "/Library/Fonts") ;; Needed to serialize font data types <rdar://problem/50164879>
>+)
>+
> ;; Security framework
> (allow mach-lookup
>     (global-name "com.apple.ocspd")
>diff --git a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>index 18a38a2843951aa48261c7001b334e7d44908ac7..aec81b344050177aaa514e0c34dba095acfa64a1 100644
>--- a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>+++ b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>@@ -288,6 +288,7 @@
>     (iokit-property-regex #"(canvas-height|canvas-width)")
>     (iokit-property "class-code")
>     (iokit-property "color-accuracy-index")
>+    (iokit-property "compatible") ;; <rdar://problem/47523516>
>     (iokit-property "compatible-device-fallback") ;; <rdar://problem/49497720>
>     (iokit-property "device-colors") ;; <rdar://problem/51322072>
>     (iokit-property "device-id")
>diff --git a/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in b/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
>index 1a31be1c76503c95b8ef0c6efc93d9e72c3ebe94..688afefaee15a6c7ea925d2440bd425abedbf48b 100644
>--- a/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
>+++ b/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
>@@ -167,6 +167,7 @@
>         "kern.hostname"
>         "kern.maxfilesperproc"
>         "kern.memorystatus_level"
>+        "kern.osproductversion" ;; <rdar://problem/51756739>
>         "kern.safeboot"
>         "kern.version"
>         "machdep.cpu.brand_string"
>@@ -635,11 +636,12 @@
> 
> #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 || PLATFORM(IOSMAC)
> (deny mach-lookup (with no-log)
>+    (global-name "com.apple.CoreServices.coreservicesd")
>+    (global-name "com.apple.DiskArbitration.diskarbitrationd")
>     (global-name "com.apple.ViewBridgeAuxiliary")
>     (global-name "com.apple.windowserver.active"))
> #endif
> 
>-
> ;; Needed to support encrypted media playback <rdar://problem/40038478>
> (allow mach-lookup
>     (global-name "com.apple.SecurityServer")

Flags:

ggaren: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 199119: 372656