Attachment 372633 Details for Bug 199111 – Patch

[patch] Patch

bug-199111-20190621102529.patch (text/plain), 2.00 KB, created by Keith Rollin on 2019-06-21 10:25:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Rollin

Created: 2019-06-21 10:25:29 PDT

Size: 2.00 KB

patch

obsolete

>Subversion Revision: 246654
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 4d853a146b7da1afffe23c4f49fd8235215af7b1..5d5eec75535445813a13a901ab3c05589b42230b 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,25 @@
>+2019-06-21  Keith Rollin  <krollin@apple.com>
>+
>+        Address reference to UIColor.groupTableViewBackgroundColor in WKPasswordView.mm
>+        https://bugs.webkit.org/show_bug.cgi?id=199111
>+        <rdar://problem/51992107>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WKPasswordView.mm is used on iOS-family devices. However, it doesn't
>+        build on tvOS or watchOS when "treat deprecation warnings as errors"
>+        is enabled. This build failure is due to a reference to
>+        UIColor.groupTableViewBackgroundColor in a branch of non-dark-mode
>+        code. Address this by surrounding the reference with
>+        ALLOW_DEPRECATED_DECLARATIONS_* macros.
>+
>+        Attempting to address the build failure by unconditionally enabling
>+        the dark-mode code works for tvOS, but fails for watchOS due to lack
>+        of dark-mode support on that platform.
>+
>+        * UIProcess/ios/WKPasswordView.mm:
>+        (-[WKPasswordView showInScrollView:]):
>+
> 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
> 
>         [GTK] Enable navigation swipe layout tests
>diff --git a/Source/WebKit/UIProcess/ios/WKPasswordView.mm b/Source/WebKit/UIProcess/ios/WKPasswordView.mm
>index b1a49a14b2df0042b69bf4920b82e96c5abc463e..e75be2d66193d3c2f3b21c632a9655aaa7fbc6e8 100644
>--- a/Source/WebKit/UIProcess/ios/WKPasswordView.mm
>+++ b/Source/WebKit/UIProcess/ios/WKPasswordView.mm
>@@ -104,7 +104,9 @@ - (void)showInScrollView:(UIScrollView *)scrollView
> #if HAVE(OS_DARK_MODE_SUPPORT)
>     [_scrollView setBackgroundColor:UIColor.systemGroupedBackgroundColor];
> #else
>+    ALLOW_DEPRECATED_DECLARATIONS_BEGIN
>     [_scrollView setBackgroundColor:UIColor.groupTableViewBackgroundColor];
>+    ALLOW_DEPRECATED_DECLARATIONS_END
> #endif
> 
>     [scrollView addSubview:self];

Actions: View | Formatted Diff | Diff

Attachments on bug 199111: 372633