WebKit Bugzilla
Attachment 372629 Details for
Bug 199104
: [GTK] Navigation gesture should use dark fallback bg color on dark themes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-199104-20190621195152.patch (text/plain), 1.94 KB, created by
Alice Mikhaylenko
on 2019-06-21 07:51:53 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alice Mikhaylenko
Created:
2019-06-21 07:51:53 PDT
Size:
1.94 KB
patch
obsolete
>Subversion Revision: 246639 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 4d853a146b7da1afffe23c4f49fd8235215af7b1..9ce4fbf411bdfcc91341dc8fc137664038aa28fd 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,17 @@ >+2019-06-21 Alexander Mikhaylenko <exalm7659@gmail.com> >+ >+ [GTK] Navigation gesture should use dark fallback bg color on dark themes >+ https://bugs.webkit.org/show_bug.cgi?id=199104 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Use theme_base_color instead of white background for swipe gesture fallback if no snapshot is found and >+ the page did not specify a color. This allows it to use dark colors for dark themes. If the color was >+ not found, still fall back to white. >+ >+ * UIProcess/gtk/ViewGestureControllerGtk.cpp: >+ (WebKit::ViewGestureController::beginSwipeGesture): >+ > 2019-06-20 Alexander Mikhaylenko <exalm7659@gmail.com> > > [GTK] Enable navigation swipe layout tests >diff --git a/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp b/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp >index aeae32bbbe911f265cc4c3e4bc96ba182066b4cf..67fd47a3f3df2c0ead82b506abd60bfe93e88936 100644 >--- a/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp >+++ b/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp >@@ -316,6 +316,13 @@ void ViewGestureController::beginSwipeGesture(WebBackForwardListItem* targetItem > } > } > >+ if (!m_currentSwipeSnapshotPattern) { >+ GdkRGBA color; >+ auto* context = gtk_widget_get_style_context(m_webPageProxy.viewWidget()); >+ if (gtk_style_context_lookup_color(context, "theme_base_color", &color)) >+ m_currentSwipeSnapshotPattern = adoptRef(cairo_pattern_create_rgba(color.red, color.green, color.blue, color.alpha)); >+ } >+ > if (!m_currentSwipeSnapshotPattern) > m_currentSwipeSnapshotPattern = adoptRef(cairo_pattern_create_rgb(1, 1, 1)); > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199104
:
372621
|
372626
| 372629