Attachment 372621 Details for Bug 199104 – Patch

[patch] Patch

bug-199104-20190621135603.patch (text/plain), 1.96 KB, created by Alice Mikhaylenko on 2019-06-21 01:56:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alice Mikhaylenko

Created: 2019-06-21 01:56:05 PDT

Size: 1.96 KB

patch

obsolete

>Subversion Revision: 246639
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 4d853a146b7da1afffe23c4f49fd8235215af7b1..a88a19e9ddee6e1f9ccad765ef421aee0a8afef7 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-21  Alexander Mikhaylenko  <exalm7659@gmail.com>
>+
>+        [GTK] Navigation gesture should use dark fallback bg color on dark themes
>+        https://bugs.webkit.org/show_bug.cgi?id=199104
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use theme_base_color instead of white background for swipe gesture fallback if no snapshot is found and
>+        the page did not specify a color. This allows it to use dark colors for dark themes.
>+
>+        * UIProcess/gtk/ViewGestureControllerGtk.cpp:
>+        (WebKit::ViewGestureController::beginSwipeGesture):
>+
> 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
> 
>         [GTK] Enable navigation swipe layout tests
>diff --git a/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp b/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp
>index aeae32bbbe911f265cc4c3e4bc96ba182066b4cf..53896c89800d45f4eb6a017357d609be32d959f6 100644
>--- a/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp
>+++ b/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp
>@@ -316,8 +316,12 @@ void ViewGestureController::beginSwipeGesture(WebBackForwardListItem* targetItem
>         }
>     }
> 
>-    if (!m_currentSwipeSnapshotPattern)
>-        m_currentSwipeSnapshotPattern = adoptRef(cairo_pattern_create_rgb(1, 1, 1));
>+    if (!m_currentSwipeSnapshotPattern) {
>+        GdkRGBA color;
>+        auto* context = gtk_widget_get_style_context(m_webPageProxy.viewWidget());
>+        gtk_style_context_lookup_color(context, "theme_base_color", &color);
>+        m_currentSwipeSnapshotPattern = adoptRef(cairo_pattern_create_rgba(color.red, color.green, color.blue, color.alpha));
>+    }
> }
> 
> void ViewGestureController::handleSwipeGesture(WebBackForwardListItem*, double, SwipeDirection)

Actions: View | Formatted Diff | Diff

Attachments on bug 199104: 372621 | 372626 | 372629