Attachment 372612 Details for Bug 199098 – Patch

[patch] Patch

bug-199098-20190620193701.patch (text/plain), 2.54 KB, created by Matt Baker on 2019-06-20 19:37:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2019-06-20 19:37:03 PDT

Size: 2.54 KB

patch

obsolete

>Subversion Revision: 246650
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 8f5c739891d81a1459c80f335ddda9e4221840c0..ecbfb23b0c57aacef5330b7837e005b1806e91c7 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-20  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: rename shadowRootPushed parameter to match protocol
>+        https://bugs.webkit.org/show_bug.cgi?id=199098
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Protocol/DOMObserver.js:
>+        (WI.DOMObserver.prototype.shadowRootPushed):
>+
> 2019-06-19  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: REGRESSION: Debugger: current call frame indicator isn't vertically centered
>diff --git a/Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js b/Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js
>index 73cbef3260d08a7b6a5e8c6c3de42e35444ca61b..7eaad2161aa4c5b8a520f2438bbf1e467051f11f 100644
>--- a/Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js
>+++ b/Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js
>@@ -37,9 +37,9 @@ WI.DOMObserver = class DOMObserver
>         WI.domManager.inspectElement(nodeId);
>     }
> 
>-    setChildNodes(parentId, payloads)
>+    setChildNodes(parentId, nodes)
>     {
>-        WI.domManager._setChildNodes(parentId, payloads);
>+        WI.domManager._setChildNodes(parentId, nodes);
>     }
> 
>     attributeModified(nodeId, name, value)
>@@ -67,9 +67,9 @@ WI.DOMObserver = class DOMObserver
>         WI.domManager._childNodeCountUpdated(nodeId, childNodeCount);
>     }
> 
>-    childNodeInserted(parentNodeId, previousNodeId, payload)
>+    childNodeInserted(parentNodeId, previousNodeId, node)
>     {
>-        WI.domManager._childNodeInserted(parentNodeId, previousNodeId, payload);
>+        WI.domManager._childNodeInserted(parentNodeId, previousNodeId, node);
>     }
> 
>     childNodeRemoved(parentNodeId, nodeId)
>@@ -77,14 +77,14 @@ WI.DOMObserver = class DOMObserver
>         WI.domManager._childNodeRemoved(parentNodeId, nodeId);
>     }
> 
>-    shadowRootPushed(parentNodeId, nodeId)
>+    shadowRootPushed(hostId, root)
>     {
>-        WI.domManager._childNodeInserted(parentNodeId, 0, nodeId);
>+        WI.domManager._childNodeInserted(hostId, 0, root);
>     }
> 
>-    shadowRootPopped(parentNodeId, nodeId)
>+    shadowRootPopped(hostId, rootId)
>     {
>-        WI.domManager._childNodeRemoved(parentNodeId, nodeId);
>+        WI.domManager._childNodeRemoved(hostId, rootId);
>     }
> 
>     customElementStateChanged(nodeId, customElementState)

Actions: View | Formatted Diff | Diff

Attachments on bug 199098: 372608 | 372612