Attachment 372601 Details for Bug 199055 – Patch

[patch] Patch

bug-199055-20190620163656.patch (text/plain), 1.51 KB, created by Megan Gardner on 2019-06-20 16:36:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2019-06-20 16:36:57 PDT

Size: 1.51 KB

patch

obsolete

>Subversion Revision: 246570
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index f17a8a4262d2b373c3c798d547f9d8f981967613..8477785d5fa9cb23964f6ea84b31aa164d55ce34 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-19  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Remove change that was causing hangs
>+        https://bugs.webkit.org/show_bug.cgi?id=199055
>+        <rdar://problem/51820516>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This fix can sometimes cause deadlocks in the UIProcess.
>+        We have a different fix that will go into UIKit <rdar://problem/51927701>.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _selectionChanged]):
>+
> 2019-06-18  Daniel Bates  <dabates@apple.com>
> 
>         REGRESSION (r240757): Cannot dismiss the keyboard on http://apple.com/apple-tv-plus
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 5cace04be6e0891e9aec6914fa006339353aafdf..6a992b69f00663c3d65098adff02a4fe217a6580 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -5772,9 +5772,6 @@ - (void)_selectionChanged
>             [(id <UITextInputDelegatePrivate>)self.inputDelegate layoutHasChanged];
>     }
> #endif
>-
>-    [self.inputDelegate selectionWillChange:self];
>-    [self.inputDelegate selectionDidChange:self];
>     
>     [_webView _didChangeEditorState];
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 199055: 372524 | 372528 | 372533 | 372563 | 372601