Attachment 372599 Details for Bug 199050 – Patch

[patch] Patch

bug-199050-20190620161513.patch (text/plain), 3.45 KB, created by Dean Johnson on 2019-06-20 16:15:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Johnson

Created: 2019-06-20 16:15:14 PDT

Size: 3.45 KB

patch

obsolete

>Subversion Revision: 246657
>diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
>index 85ef41142eef66679befe236b85fdad455987113..f790fae62dd2822bf6a1de1f7ba7e7664225b4d4 100644
>--- a/Websites/perf.webkit.org/ChangeLog
>+++ b/Websites/perf.webkit.org/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-20  Dean Johnson  <dean_johnson@apple.com>
>+
>+        [perf.webkit.org] Update summary page calculations to use mean instead of median
>+        https://bugs.webkit.org/show_bug.cgi?id=199050
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * public/v3/pages/summary-page.js:
>+        (SummaryPageConfigurationGroup): Updated 'median' references to 'mean'.
>+        (SummaryPageConfigurationGroup.set _startAndEndPointForTimeRange): Factored out logic for finding data
>+        points in a timeSeries, within a specified timeRange.
>+        (SummaryPageConfigurationGroup.set _meanForTimeRange): New. Returns the mean of a timeSeries across a
>+        given timeRange.
>+
> 2019-06-17  Dewei Zhu  <dewei_zhu@apple.com>
> 
>         Customizable test group form should allow user to supply a revision prefix of a commit and revision starts with 'r'.
>diff --git a/Websites/perf.webkit.org/public/v3/pages/summary-page.js b/Websites/perf.webkit.org/public/v3/pages/summary-page.js
>index 05c601314e1de57bfc07a6395c62909d103148ac..e4619b197487ce972c18c80afe89bfdb2cea887f 100644
>--- a/Websites/perf.webkit.org/public/v3/pages/summary-page.js
>+++ b/Websites/perf.webkit.org/public/v3/pages/summary-page.js
>@@ -346,21 +346,21 @@ class SummaryPageConfigurationGroup {
>             var baselineTimeSeries = set.fetchedTimeSeries('baseline', false, false);
>             var currentTimeSeries = set.fetchedTimeSeries('current', false, false);
> 
>-            var baselineMedian = SummaryPageConfigurationGroup._medianForTimeRange(baselineTimeSeries, timeRange);
>-            var currentMedian = SummaryPageConfigurationGroup._medianForTimeRange(currentTimeSeries, timeRange);
>+            const baselineMean = SummaryPageConfigurationGroup._meanForTimeRange(baselineTimeSeries, timeRange);
>+            const currentMean = SummaryPageConfigurationGroup._meanForTimeRange(currentTimeSeries, timeRange);
>             var platform = Platform.findById(set.platformId());
>-            if (!currentMedian)
>+            if (!currentMean)
>                 self._missingPlatforms.add(platform);
>-            else if (!baselineMedian)
>+            else if (!baselineMean)
>                 self._platformsWithoutBaseline.add(platform);
> 
>-            setToRatio.set(set, currentMedian / baselineMedian);
>+            setToRatio.set(set, currentMean / baselineMean);
>         }).catch(function () {
>             setToRatio.set(set, NaN);
>         });
>     }
> 
>-    static _medianForTimeRange(timeSeries, timeRange)
>+    static _startAndEndPointForTimeRange(timeSeries, timeRange)
>     {
>         if (!timeSeries.firstPoint())
>             return NaN;
>@@ -371,6 +371,12 @@ class SummaryPageConfigurationGroup {
>         if (!endPoint || startPoint == afterEndPoint)
>             endPoint = afterEndPoint;
> 
>-        return Statistics.median(timeSeries.viewBetweenPoints(startPoint, endPoint).values());
>+        return [startPoint, endPoint];
>+    }
>+
>+    static _meanForTimeRange(timeSeries, timeRange)
>+    {
>+        const [startPoint, endPoint] = SummaryPageConfigurationGroup._startAndEndPointForTimeRange(timeSeries, timeRange);
>+        return Statistics.mean(timeSeries.viewBetweenPoints(startPoint, endPoint).values());
>     }
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 199050: 372539 | 372599