Attachment 372573 Details for Bug 199073 – Patch

[patch] Patch

bug-199073-20190620141855.patch (text/plain), 3.27 KB, created by Aakash Jain on 2019-06-20 11:18:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-06-20 11:18:56 PDT

Size: 3.27 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 246642)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-06-20  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Add unit tests for AnalyzeCompileWebKitResults
>+        https://bugs.webkit.org/show_bug.cgi?id=199073
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
>+
> 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
> 
>         [GTK] Enable navigation swipe layout tests
>Index: Tools/BuildSlaveSupport/ews-build/steps_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(revision 246642)
>+++ Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(working copy)
>@@ -34,7 +34,7 @@ from twisted.internet import error, reac
> from twisted.python import failure, log
> from twisted.trial import unittest
> 
>-from steps import (AnalyzeAPITestsResults, ApplyPatch, ArchiveBuiltProduct, ArchiveTestResults,
>+from steps import (AnalyzeAPITestsResults, AnalyzeCompileWebKitResults, ApplyPatch, ArchiveBuiltProduct, ArchiveTestResults,
>                    CheckOutSource, CheckPatchRelevance, CheckStyle, CleanBuild, CleanWorkingDirectory,
>                    CompileJSCOnly, CompileJSCOnlyToT, CompileWebKit, CompileWebKitToT, ConfigureBuild,
>                    DownloadBuiltProduct, ExtractBuiltProduct, ExtractTestResults, KillOldProcesses,
>@@ -48,6 +48,13 @@ from buildbot.test.fake.fakebuild import
> FakeBuild.addStepsAfterCurrentStep = lambda FakeBuild, step_factories: None
> 
> 
>+def mock_step(step, logs='', results=SUCCESS, stopped=False, properties=None):
>+    step.logs = logs
>+    step.results = results
>+    step.stopped = stopped
>+    return step
>+
>+
> class ExpectMasterShellCommand(object):
>     def __init__(self, command, workdir=None, env=None, usePTY=0):
>         self.args = command
>@@ -545,6 +552,33 @@ class TestCompileWebKitToT(BuildStepMixi
>         return self.runStep()
> 
> 
>+class TestAnalyzeCompileWebKitResults(BuildStepMixinAdditions, unittest.TestCase):
>+    def setUp(self):
>+        self.longMessage = True
>+        return self.setUpBuildStep()
>+
>+    def tearDown(self):
>+        return self.tearDownBuildStep()
>+
>+    def test_patch_with_build_failure(self):
>+        previous_steps = [
>+            mock_step(CompileWebKit(), results=FAILURE),
>+            mock_step(CompileWebKitToT(), results=SUCCESS),
>+        ]
>+        self.setupStep(AnalyzeCompileWebKitResults(), previous_steps=previous_steps)
>+        self.expectOutcome(result=FAILURE, state_string='Patch does not build (failure)')
>+        return self.runStep()
>+
>+    def test_patch_with_ToT_failure(self):
>+        previous_steps = [
>+            mock_step(CompileWebKit(), results=FAILURE),
>+            mock_step(CompileWebKitToT(), results=FAILURE),
>+        ]
>+        self.setupStep(AnalyzeCompileWebKitResults(), previous_steps=previous_steps)
>+        self.expectOutcome(result=FAILURE, state_string='Unable to build WebKit without patch, retrying build (failure)')
>+        return self.runStep()
>+
>+
> class TestCompileJSCOnly(BuildStepMixinAdditions, unittest.TestCase):
>     def setUp(self):
>         self.longMessage = True

Actions: View | Formatted Diff | Diff

Attachments on bug 199073: 372573