WebKit Bugzilla
Attachment 372567 Details for
Bug 199047
: Web Inspector: current call frame indicator not visible in dark mode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-199047-20190620103914.patch (text/plain), 2.62 KB, created by
Matt Baker
on 2019-06-20 10:39:15 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Matt Baker
Created:
2019-06-20 10:39:15 PDT
Size:
2.62 KB
patch
obsolete
>Subversion Revision: 246619 >diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index ba07a2c81596cada6b8b7013140f55cb67999820..f02cad861b6ada244b131de45d46a067a0574ef0 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,22 @@ >+2019-06-20 Matt Baker <mattbaker@apple.com> >+ >+ Web Inspector: current call frame indicator not visible in dark mode >+ https://bugs.webkit.org/show_bug.cgi?id=199047 >+ <rdar://problem/51922895> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ The selected CallFrameTreeElement can appear in four possible states: >+ light/dark mode and focused/unfocused. When unfocused and in light mode, >+ the current call frame indicator should be dark gray. In the other cases >+ the indicator should be white. This is consistent with Xcode. >+ >+ * UserInterface/Views/CallFrameTreeElement.css: >+ (.tree-outline .item.call-frame.selected .status > .status-image): >+ (.tree-outline .item.call-frame:not(.selected) .status > .status-image): >+ (@media (prefers-color-scheme: dark)): >+ (.tree-outline .item.call-frame .status > .status-image): >+ > 2019-06-19 Matt Baker <mattbaker@apple.com> > > Web Inspector: Remove unused _pendingFilter from NetworkTableContentView >diff --git a/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css b/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css >index 8871001ec9c1b56df56e3b86eb6aea0302179e1c..25d994f49b6b0f147f2b627d9c59b1c0dd5b7b1e 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css >+++ b/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css >@@ -48,14 +48,14 @@ body[dir=rtl] .tree-outline .item.call-frame .status { > transform: scaleX(-1); > } > >-.tree-outline .item.call-frame .status > .status-image { >+.tree-outline .item.call-frame.selected .status > .status-image { > width: 17px; > height: 17px; >- fill: var(--border-color); >+ fill: var(--border-color-dark); > } > >-.tree-outline .item.call-frame.selected .status > .status-image { >- fill: var(--border-color-dark); >+.tree-outline .item.call-frame:not(.selected) .status > .status-image { >+ display: none; > } > > .tree-outline:focus .item.call-frame.selected .status > .status-image { >@@ -101,3 +101,9 @@ body[dir=rtl] .tree-outline .item.call-frame .status { > .tree-outline.single-thread .item.call-frame.async-boundary::before { > width: 20px; > } >+ >+@media (prefers-color-scheme: dark) { >+ .tree-outline .item.call-frame.selected .status > .status-image { >+ fill: var(--selected-foreground-color); >+ } >+}
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199047
:
372507
|
372508
|
372567
|
373532
|
373535