Attachment 372563 Details for Bug 199055 – Patch

[patch] Patch

bug-199055-20190620095437.patch (text/plain), 2.41 KB, created by Megan Gardner on 2019-06-20 09:54:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2019-06-20 09:54:38 PDT

Size: 2.41 KB

patch

obsolete

>Subversion Revision: 246570
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index f17a8a4262d2b373c3c798d547f9d8f981967613..f47642718a17902fb1eb4304ffd5b568a144e8cd 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-06-19  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Correctly notify the keyboard that the selection has changed and the keyboard needs to be update.
>+        https://bugs.webkit.org/show_bug.cgi?id=199055
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use the plumbing we made in UIKit to alert the keyboard that the selection has changed.
>+        The previous fix would occationally result in deadlocks.
>+
>+        * Platform/spi/ios/UIKitSPI.h:
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView insertText:]):
>+        (-[WKContentView _selectionChanged]):
>+
> 2019-06-18  Daniel Bates  <dabates@apple.com>
> 
>         REGRESSION (r240757): Cannot dismiss the keyboard on http://apple.com/apple-tv-plus
>diff --git a/Source/WebKit/Platform/spi/ios/UIKitSPI.h b/Source/WebKit/Platform/spi/ios/UIKitSPI.h
>index 7444489928009ce8f9f11d1e43239af14826e8ba..9fe05775872af3eb3eaa0634bc95a9200bfde205 100644
>--- a/Source/WebKit/Platform/spi/ios/UIKitSPI.h
>+++ b/Source/WebKit/Platform/spi/ios/UIKitSPI.h
>@@ -1068,6 +1068,10 @@ typedef NS_OPTIONS(NSInteger, UIWKDocumentRequestFlags) {
> 
> #endif // USE(APPLE_INTERNAL_SDK)
> 
>+@interface UIWKTextInteractionAssistant (Staging_51927701)
>+- (void)postInputResponderCapabilitiesChangedNotification;
>+@end
>+
> @interface UIGestureRecognizer (Staging_45970040)
> @property (nonatomic, readonly, getter=_modifierFlags) UIKeyModifierFlags modifierFlags;
> @end
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 5cace04be6e0891e9aec6914fa006339353aafdf..eaedb4674637e125d70265430bfe4ee05d28944f 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -5773,8 +5773,8 @@ - (void)_selectionChanged
>     }
> #endif
> 
>-    [self.inputDelegate selectionWillChange:self];
>-    [self.inputDelegate selectionDidChange:self];
>+    if ([_textSelectionAssistant respondsToSelector:@selector(postInputResponderCapabilitiesChangedNotification)])
>+        [_textSelectionAssistant postInputResponderCapabilitiesChangedNotification];
>     
>     [_webView _didChangeEditorState];
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 199055: 372524 | 372528 | 372533 | 372563 | 372601