Attachment 372562 Details for Bug 197355 – Patch

[patch] Patch

bug-197355-20190620175042.patch (text/plain), 1.92 KB, created by Charlie Turner on 2019-06-20 09:50:43 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Charlie Turner

Created: 2019-06-20 09:50:43 PDT

Size: 1.92 KB

patch

obsolete

>Subversion Revision: 246536
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 681ccb6215f852bfb2669b8667e190a29895113c..271e9c5402b6416166644bb61f6b5296565b2e42 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-06-20  Charlie Turner  <cturner@igalia.com>
>+
>+        [GStreamer][MSE] Pausing video sometimes causes skip to finish
>+        https://bugs.webkit.org/show_bug.cgi?id=197355
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Work in progress?
>+
>+        No new tests (OOPS!).
>+
>+        * platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
>+        (WebCore::MediaPlayerPrivateGStreamerMSE::currentMediaTime const):
>+        Assuming that when m_eosPending is on and we're paused() that the
>+        network resource is fully loaded and the end is reached is clearly
>+        wrong. Whether this is now correct is unclear...
>+
> 2019-06-18  Zan Dobersek  <zdobersek@igalia.com>
> 
>         [WebGL] Extensions3DOpenGLES::bindVertexArrayOES() should allow zero array object
>diff --git a/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp b/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
>index a88fc8b252a620b361f569be3a8ef313eb32ba74..4e9d19d8527d69620cf5aa941073628381b3c9f0 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
>@@ -758,7 +758,7 @@ MediaTime MediaPlayerPrivateGStreamerMSE::currentMediaTime() const
> {
>     MediaTime position = MediaPlayerPrivateGStreamer::currentMediaTime();
> 
>-    if (m_eosPending && (paused() || (position >= durationMediaTime()))) {
>+    if (m_eosPending && position >= durationMediaTime()) {
>         if (m_networkState != MediaPlayer::Loaded) {
>             m_networkState = MediaPlayer::Loaded;
>             m_player->networkStateChanged();

Actions: View | Formatted Diff | Diff

Attachments on bug 197355: 372562 | 372627