Attachment 372558 Details for Bug 199069 – Patch

[patch] Patch

bug-199069-20190620162557.patch (text/plain), 1.41 KB, created by Charlie Turner on 2019-06-20 08:25:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Charlie Turner

Created: 2019-06-20 08:25:58 PDT

Size: 1.41 KB

patch

obsolete

>Subversion Revision: 246536
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 5f21dbdbff30847cc3f9d43c34489b134cc5b0ad..9da9dbb275ce6ba7e8dc284fa8741b7f36ee6866 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-20  Charlie Turner  <cturner@igalia.com>
>+
>+        [GTK] Make startup pause available in DEVELOPER_MODE rather than DEBUG.
>+        https://bugs.webkit.org/show_bug.cgi?id=199069
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/gtk/WebProcessMainGtk.cpp: Allow developers to pause
>+        the web process in DEVELOPER_MODE rather than only DEBUG, matching
>+        the WPE behaviour and also the purpose of DEVELOPER_MODE.
>+
> 2019-06-18  Dean Jackson  <dino@apple.com>
> 
>         Attachment elements are missing context menu previews
>diff --git a/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp b/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp
>index b19b940ba56008e96c1a3cc944c81675ab3281c6..4c0afbd6132f1e9dbc77ee3c0b0ecb2ea0e7c7db 100644
>--- a/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp
>+++ b/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp
>@@ -45,7 +45,7 @@ class WebProcessMain final: public AuxiliaryProcessMainBase {
> public:
>     bool platformInitialize() override
>     {
>-#ifndef NDEBUG
>+#if ENABLE(DEVELOPER_MODE)
>         if (g_getenv("WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH"))
>             g_usleep(30 * G_USEC_PER_SEC);
> #endif

Actions: View | Formatted Diff | Diff

Attachments on bug 199069: 372558