Attachment 372557 Details for Bug 199068 – Patch

[patch] Patch

bug-199068-20190620171603.patch (text/plain), 2.01 KB, created by Antoine Quint on 2019-06-20 08:16:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antoine Quint

Created: 2019-06-20 08:16:04 PDT

Size: 2.01 KB

patch

obsolete

>Subversion Revision: 246633
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 54305a0c8d8c23d64e9d0d6f8f7aba365f5f3459..9c5a56f0dfc62faf6187af9b8c2f42986706fce8 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-20  Antoine Quint  <graouts@apple.com>
>+
>+        fast/events/ios/click-event-and-display-contents.html times out on iPad
>+        https://bugs.webkit.org/show_bug.cgi?id=199068
>+        <rdar://problem/51899547>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Querying the bounds of a "display: contents" element will always return 0 width and height. So let's position the element at 0,0
>+        so that we can send a tap at that location and reliably tap on that element.
>+
>+        * fast/events/ios/click-event-and-display-contents.html:
>+
> 2019-06-19  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         [WHLSL] Hook up common texture functions
>diff --git a/LayoutTests/fast/events/ios/click-event-and-display-contents.html b/LayoutTests/fast/events/ios/click-event-and-display-contents.html
>index 73bd2dd36bdc610e8d132b4fae85f226fcd8cd87..33a1eb113e5ad40111009e146a685da0859a7031 100644
>--- a/LayoutTests/fast/events/ios/click-event-and-display-contents.html
>+++ b/LayoutTests/fast/events/ios/click-event-and-display-contents.html
>@@ -4,6 +4,11 @@
> <title>This tests that a tap on an element with display: contents dispatches a "click" event.</title>
> <script src="../../../resources/basic-gestures.js"></script>
> <style>
>+
>+body {
>+    margin: 0;
>+}
>+
> #target {
>     width: 100px;
>     height: 100px;
>@@ -26,14 +31,11 @@
>     const target = document.getElementById("target");
> 
>     target.addEventListener("click", event => {
>-        document.getElementById("target").innerText = "PASS";
>+        target.innerText = "PASS";
>         testRunner.notifyDone();
>     });
> 
>-    const bounds = target.getBoundingClientRect();
>-    const x = bounds.left + bounds.width / 2;
>-    const y = bounds.top + bounds.height / 2;
>-    tapAtPoint(x, y);
>+    tapAtPoint(0, 0);
> })();
> 
> </script>

Flags:

dino: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 199068: 372557