Attachment 372543 Details for Bug 199061 – Fixes the bug

[patch] Fixes the bug

bug-199061-20190620000754.patch (text/plain), 1.44 KB, created by Ryosuke Niwa on 2019-06-20 00:07:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2019-06-20 00:07:54 PDT

Size: 1.44 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 246630)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-06-20  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        REGRESSION(r245912): Crash in TextIterator::range via visiblePositionForIndexUsingCharacterIterator
>+        https://bugs.webkit.org/show_bug.cgi?id=199061
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Avoid calling CharacterIterator::range when it's at the end. Otherwise, we'd crash with null pointer dereferencing.
>+
>+        Unfortunately no new tests since we don't have any reproducible test case.
>+
>+        * editing/Editing.cpp:
>+        (WebCore::visiblePositionForIndexUsingCharacterIterator):
>+
> 2019-06-19  Justin Fan  <justin_fan@apple.com>
> 
>         [WHLSL] Create a shading language test harness
>Index: Source/WebCore/editing/Editing.cpp
>===================================================================
>--- Source/WebCore/editing/Editing.cpp	(revision 246630)
>+++ Source/WebCore/editing/Editing.cpp	(working copy)
>@@ -1127,7 +1127,8 @@ VisiblePosition visiblePositionForIndexU
>         auto range = it.range();
>         if (range->startPosition() == range->endPosition()) {
>             it.advance(1);
>-            return VisiblePosition(it.range()->startPosition());
>+            if (!it.atEnd())
>+                return VisiblePosition(it.range()->startPosition());
>         }
>     }
>

Flags:

wenson_hsieh: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 199061: 372543