Attachment 372541 Details for Bug 199054 – Patch

[patch] Patch

bug-199054-20190619231132.patch (text/plain), 2.72 KB, created by Dean Johnson on 2019-06-19 23:11:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Johnson

Created: 2019-06-19 23:11:32 PDT

Size: 2.72 KB

patch

obsolete

>Subversion Revision: 246612
>diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
>index 1a42ab199a0cf4dd339f9d2faf5013cc2cc351f4..0a3791c93870223d54c77f05e54cefc810d998de 100644
>--- a/Websites/perf.webkit.org/ChangeLog
>+++ b/Websites/perf.webkit.org/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-06-19  Dean Johnson  <dean_johnson@apple.com>
>+
>+        [perf.webkit.org] When calculating a ratio for the summary page, use a rolling window for last available data instead of only the last available data point
>+        https://bugs.webkit.org/show_bug.cgi?id=199054
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Since we set the "last 24 hours" window to the current time, and it can take hours between a commit landing,
>+        build products becoming available, and testing to occur, this 24 hour window will always have a margin that
>+        contains no data to evaluate. Additionally, using only a single data point when no data is available in the
>+        past 24 hours can lead to misrepresented results due to a single outlier run before a configuration stopped
>+        producing results.
>+
>+        * public/v3/pages/summary-page.js:
>+        (SummaryPageConfigurationGroup.set _startAndEndPointForTimeRange): Use a rolling window based on the first available
>+        data point before the end of a time range.
>+
> 2019-06-19  Dean Johnson  <dean_johnson@apple.com>
> 
>         [perf.webkit.org] Add 'back in time' feature for Summary pages
>diff --git a/Websites/perf.webkit.org/public/v3/pages/summary-page.js b/Websites/perf.webkit.org/public/v3/pages/summary-page.js
>index 983e29744a379555a4e4c18c168fae6820ecddab..3a1d9adae4a11b043ab2b39e0d3a55ccc4507943 100644
>--- a/Websites/perf.webkit.org/public/v3/pages/summary-page.js
>+++ b/Websites/perf.webkit.org/public/v3/pages/summary-page.js
>@@ -380,8 +380,12 @@ class SummaryPageConfigurationGroup {
>         if (!timeSeries.firstPoint())
>             return NaN;
> 
>-        const startPoint = timeSeries.findPointAfterTime(timeRange[0]) || timeSeries.lastPoint();
>-        const afterEndPoint = timeSeries.findPointAfterTime(timeRange[1]) || timeSeries.lastPoint();
>+        // If no data is available in the provided timeRange, offset the search window to
>+        // the last available data point.
>+        const offset = !timeSeries.findPointAfterTime(timeRange[0]) ? timeRange[0] - timeSeries.lastPoint().time : 0;
>+        const startPoint = timeSeries.findPointAfterTime(timeRange[0] - offset) || timeSeries.lastPoint();
>+        const afterEndPoint = timeSeries.findPointAfterTime(timeRange[1] - offset) || timeSeries.lastPoint();
>+
>         let endPoint = timeSeries.previousPoint(afterEndPoint);
>         if (!endPoint || startPoint == afterEndPoint)
>             endPoint = afterEndPoint;

Actions: View | Formatted Diff | Diff

Attachments on bug 199054: 372534 | 372535 | 372541