Attachment 372536 Details for Bug 199058 – Incorrect upload for `webkit upload-patch -g HEAD~2`

Incorrect upload for `webkit upload-patch -g HEAD~2`

incorrect-upload-HEAD~2.diff (text/plain), 4.31 KB, created by Dean Johnson on 2019-06-19 23:03:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Johnson

Created: 2019-06-19 23:03:24 PDT

Size: 4.31 KB

patch

obsolete

>commit 7df5f9b5a5e730baacf91b9385a321ee3c1b808d
>Author: Dean Johnson <dean_johnson@apple.com>
>Date:   Wed Jun 19 22:36:59 2019 -0700
>
>    [perf.webkit.org] Update summary page calculations to use mean instead of median
>    https://bugs.webkit.org/show_bug.cgi?id=199050
>    
>    Reviewed by NOBODY (OOPS!).
>    
>    * public/v3/pages/summary-page.js:
>    (SummaryPageConfigurationGroup): Updated 'median' references to 'mean'.
>    (SummaryPageConfigurationGroup.set _startAndEndPointForTimeRange): Factored out logic for finding data
>    points in a timeSeries, within a specified timeRange.
>    (SummaryPageConfigurationGroup.set _meanForTimeRange): New. Same as _medianForTimeRaange, but uses
>    Statistics.mean.
>    (SummaryPageConfigurationGroup.set _medianForTimeRange):
>
>diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
>index 85ef41142ee..a08c0cca9ef 100644
>--- a/Websites/perf.webkit.org/ChangeLog
>+++ b/Websites/perf.webkit.org/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-06-19  Dean Johnson  <dean_johnson@apple.com>
>+
>+        [perf.webkit.org] Update summary page calculations to use mean instead of median
>+        https://bugs.webkit.org/show_bug.cgi?id=199050
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * public/v3/pages/summary-page.js:
>+        (SummaryPageConfigurationGroup): Updated 'median' references to 'mean'.
>+        (SummaryPageConfigurationGroup.set _startAndEndPointForTimeRange): Factored out logic for finding data
>+        points in a timeSeries, within a specified timeRange.
>+        (SummaryPageConfigurationGroup.set _meanForTimeRange): New. Same as _medianForTimeRaange, but uses
>+        Statistics.mean.
>+        (SummaryPageConfigurationGroup.set _medianForTimeRange):
>+
> 2019-06-17  Dewei Zhu  <dewei_zhu@apple.com>
> 
>         Customizable test group form should allow user to supply a revision prefix of a commit and revision starts with 'r'.
>diff --git a/Websites/perf.webkit.org/public/v3/pages/summary-page.js b/Websites/perf.webkit.org/public/v3/pages/summary-page.js
>index 05c601314e1..089ed982d7b 100644
>--- a/Websites/perf.webkit.org/public/v3/pages/summary-page.js
>+++ b/Websites/perf.webkit.org/public/v3/pages/summary-page.js
>@@ -346,21 +346,21 @@ class SummaryPageConfigurationGroup {
>             var baselineTimeSeries = set.fetchedTimeSeries('baseline', false, false);
>             var currentTimeSeries = set.fetchedTimeSeries('current', false, false);
> 
>-            var baselineMedian = SummaryPageConfigurationGroup._medianForTimeRange(baselineTimeSeries, timeRange);
>-            var currentMedian = SummaryPageConfigurationGroup._medianForTimeRange(currentTimeSeries, timeRange);
>+            var baselineMean = SummaryPageConfigurationGroup._meanForTimeRange(baselineTimeSeries, timeRange);
>+            var currentMean = SummaryPageConfigurationGroup._meanForTimeRange(currentTimeSeries, timeRange);
>             var platform = Platform.findById(set.platformId());
>-            if (!currentMedian)
>+            if (!currentMean)
>                 self._missingPlatforms.add(platform);
>-            else if (!baselineMedian)
>+            else if (!baselineMean)
>                 self._platformsWithoutBaseline.add(platform);
> 
>-            setToRatio.set(set, currentMedian / baselineMedian);
>+            setToRatio.set(set, currentMean / baselineMean);
>         }).catch(function () {
>             setToRatio.set(set, NaN);
>         });
>     }
> 
>-    static _medianForTimeRange(timeSeries, timeRange)
>+    static _startAndEndPointForTimeRange(timeSeries, timeRange)
>     {
>         if (!timeSeries.firstPoint())
>             return NaN;
>@@ -371,6 +371,18 @@ class SummaryPageConfigurationGroup {
>         if (!endPoint || startPoint == afterEndPoint)
>             endPoint = afterEndPoint;
> 
>+        return [startPoint, endPoint];
>+    }
>+
>+    static _medianForTimeRange(timeSeries, timeRange)
>+    {
>+        var [startPoint, endPoint] = SummaryPageConfigurationGroup._startAndEndPointForTimeRange(timeSeries, timeRange);
>         return Statistics.median(timeSeries.viewBetweenPoints(startPoint, endPoint).values());
>     }
>+
>+    static _meanForTimeRange(timeSeries, timeRange)
>+    {
>+        var [startPoint, endPoint] = SummaryPageConfigurationGroup._startAndEndPointForTimeRange(timeSeries, timeRange);
>+        return Statistics.mean(timeSeries.viewBetweenPoints(startPoint, endPoint).values());
>+    }
> }

Actions: View

Attachments on bug 199058: 372536 | 372537