WebKit Bugzilla
Attachment 372524 Details for
Bug 199055
: Remove change that was causing hangs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-199055-20190619203647.patch (text/plain), 2.60 KB, created by
Megan Gardner
on 2019-06-19 20:36:47 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Megan Gardner
Created:
2019-06-19 20:36:47 PDT
Size:
2.60 KB
patch
obsolete
>Subversion Revision: 246570 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index f17a8a4262d2b373c3c798d547f9d8f981967613..5445fc264d8d60ac21bd8724acbe70b680bced3f 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,17 @@ >+2019-06-19 Megan Gardner <megan_gardner@apple.com> >+ >+ Better fix for keyboard buttons >+ https://bugs.webkit.org/show_bug.cgi?id=199055 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Calling selectionWillChange/selectionDidChange will still sometimes cause a deadlock in the UIProcess. >+ We only actually need to make sure that this notification is called, so only to that instead. >+ >+ * Platform/spi/ios/UIKitSPI.h: >+ * UIProcess/ios/WKContentViewInteraction.mm: >+ (-[WKContentView _selectionChanged]): >+ > 2019-06-18 Daniel Bates <dabates@apple.com> > > REGRESSION (r240757): Cannot dismiss the keyboard on http://apple.com/apple-tv-plus >diff --git a/Source/WebKit/Platform/spi/ios/UIKitSPI.h b/Source/WebKit/Platform/spi/ios/UIKitSPI.h >index 7444489928009ce8f9f11d1e43239af14826e8ba..0342ce0c64dd50514ab582e729260c6e8297aaa7 100644 >--- a/Source/WebKit/Platform/spi/ios/UIKitSPI.h >+++ b/Source/WebKit/Platform/spi/ios/UIKitSPI.h >@@ -1066,6 +1066,9 @@ typedef NS_OPTIONS(NSInteger, UIWKDocumentRequestFlags) { > @property (nonatomic, retain) id <NSCopying> inputElementIdentifier; > @end > >+NSString *const UITextInputResponderCapabilitiesChangedSelectionDidChangeKey = @"UITextInputResponderCapabilitiesChangedSelectionDidChangeKey"; >+NSNotificationName const UITextInputResponderCapabilitiesChangedNotification = @"UITextInputResponderCapabilitiesChangedNotification"; >+ > #endif // USE(APPLE_INTERNAL_SDK) > > @interface UIGestureRecognizer (Staging_45970040) >diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >index 5cace04be6e0891e9aec6914fa006339353aafdf..a06c7f2faf0381f3d9a4f0b1e67fefc351f7aa4d 100644 >--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >@@ -5773,8 +5773,9 @@ - (void)_selectionChanged > } > #endif > >- [self.inputDelegate selectionWillChange:self]; >- [self.inputDelegate selectionDidChange:self]; >+ NSMutableDictionary *userInfo = [NSMutableDictionary dictionaryWithCapacity:2]; >+ userInfo[UITextInputResponderCapabilitiesChangedSelectionDidChangeKey] = @(YES); >+ [[NSNotificationCenter defaultCenter] postNotificationName:UITextInputResponderCapabilitiesChangedNotification object:nil userInfo:userInfo]; > > [_webView _didChangeEditorState]; > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199055
:
372524
|
372528
|
372533
|
372563
|
372601