WebKit Bugzilla
Attachment 372488 Details for
Bug 199022
: Web Inspector: Dark Mode: inactive tab bar item should get darker on hover
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-199022-20190619131123.patch (text/plain), 5.28 KB, created by
Devin Rousso
on 2019-06-19 13:11:23 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Devin Rousso
Created:
2019-06-19 13:11:23 PDT
Size:
5.28 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index abcf04b8ebe2125d37f2aced2946b1f61336384b..2194e4ae438ba53d7ac7f89c1558bbbd4060eca7 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,24 @@ >+2019-06-19 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: Dark Mode: inactive tab bar item should get darker on hover >+ https://bugs.webkit.org/show_bug.cgi?id=199022 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UserInterface/Views/TabBar.css: >+ (.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover): >+ (@media not (prefers-color-scheme: dark) .tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon): >+ (@media (prefers-color-scheme: dark) .tab-bar): >+ (@media (prefers-color-scheme: dark) .tab-bar > .item): >+ (@media (prefers-color-scheme: dark) .tab-bar > .item:not(.disabled).selected): >+ (@media (prefers-color-scheme: dark) .tab-bar:not(.animating) > .item:not(.selected):hover): >+ (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar): >+ (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar > .item): >+ (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar > .item.selected): >+ >+ * UserInterface/Views/Toolbar.css: >+ (@media (prefers-color-scheme: dark) body .toolbar): >+ > 2019-06-18 Devin Rousso <drousso@apple.com> > > Web Inspector: Network: detail view shouldn't stay open when the related entry is removed >diff --git a/Source/WebInspectorUI/UserInterface/Views/TabBar.css b/Source/WebInspectorUI/UserInterface/Views/TabBar.css >index 3a938e606be4df8b597551ef915aee898e585d58..a0b98480021806b18797bd97e3813589257bae10 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/TabBar.css >+++ b/Source/WebInspectorUI/UserInterface/Views/TabBar.css >@@ -138,7 +138,7 @@ body[dir=rtl] .tab-bar.dragging-tab > .item.selected { > } > > .tab-bar:not(.animating) > .item:not(.selected, .disabled):hover { >- background-position: 0 100%; >+ background-image: linear-gradient(to bottom, hsl(0, 0%, 67%), hsl(0, 0%, 64%)); > border-top-color: var(--tab-item-dark-border-color); > } > >@@ -251,8 +251,10 @@ body:not(.window-inactive) .tab-bar.single-tab > .item.default-tab:hover > .clos > opacity: 0.35; > } > >-.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon { >- opacity: 0.6; >+@media not (prefers-color-scheme: dark) { >+ .tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon { >+ opacity: 0.6; >+ } > } > > .tab-bar > .item > .title { >@@ -360,8 +362,7 @@ body.window-inactive .tab-bar.animating.closing-tab > .item.selected { > > @media (prefers-color-scheme: dark) { > .tab-bar { >- background-image: none; >- background-color: hsl(0, 0%, 23%); >+ background-image: linear-gradient(to bottom, hsl(0, 0%, 12%), hsl(0, 0%, 10%)); > > --tab-item-border-color: hsl(0, 0%, 36%); > >@@ -373,8 +374,7 @@ body.window-inactive .tab-bar.animating.closing-tab > .item.selected { > } > > .tab-bar > .item { >- background-image: none; >- background-color: hsl(0, 0%, 10%); >+ background-image: linear-gradient(to bottom, hsl(0, 0%, 12%), hsl(0, 0%, 10%)); > } > > .tab-bar > .item > .title { >@@ -382,13 +382,12 @@ body.window-inactive .tab-bar.animating.closing-tab > .item.selected { > } > > .tab-bar > .item:not(.disabled).selected { >- background-image: none; >- background-color: hsl(0, 0%, 21%); >+ background-image: linear-gradient(to bottom, hsl(0, 0%, 23%), hsl(0, 0%, 21%)); > border-top-color: hsl(0, 0%, 37%); > } > > .tab-bar:not(.animating) > .item:not(.selected):hover { >- background-color: hsl(0, 0%, 15%); >+ background-image: linear-gradient(to bottom, hsl(0, 0%, 11%), hsl(0, 0%, 9%)); > } > > .tab-bar > .item > .close, >@@ -401,16 +400,16 @@ body.window-inactive .tab-bar.animating.closing-tab > .item.selected { > border-bottom-color: var(--tab-item-border-color); > > background-image: none !important; >- background-color: hsl(0, 0%, 17%) !important; >+ background-color: hsl(0, 0%, 13%) !important; > } > > body.window-inactive .tab-bar > .item { > background-image: none !important; >- background-color: hsl(0, 0%, 17%) !important; >+ background-color: hsl(0, 0%, 13%) !important; > } > > body.window-inactive .tab-bar > .item.selected { >- background-color: var(--background-color) !important; >+ background-color: hsl(0, 0%, 19%) !important; > } > > body.window-inactive .tab-bar > .item > .title { >diff --git a/Source/WebInspectorUI/UserInterface/Views/Toolbar.css b/Source/WebInspectorUI/UserInterface/Views/Toolbar.css >index fff0b6e1904d96b2eb1eddd7691594d2fe29eb39..3297f8afbde752f11fe54cd2fb6eb071f94d53dc 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/Toolbar.css >+++ b/Source/WebInspectorUI/UserInterface/Views/Toolbar.css >@@ -209,7 +209,7 @@ body.latest-mac.window-inactive .toolbar .dashboard-container { > > @media (prefers-color-scheme: dark) { > body .toolbar { >- background-image: linear-gradient(to bottom, hsl(0, 0%, 25%), hsl(0, 0%, 22%)); >+ background-image: linear-gradient(to bottom, hsl(0, 0%, 26%), hsl(0, 0%, 23%)); > box-shadow: none; > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199022
: 372488 |
372489