Attachment 372486 Details for Bug 199026 – Patch

[patch] Patch

bug-199026-20190619124134.patch (text/plain), 2.57 KB, created by Matt Baker on 2019-06-19 12:41:35 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2019-06-19 12:41:35 PDT

Size: 2.57 KB

patch

obsolete

>Subversion Revision: 246500
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 926b90cc67776b20e5fc5f9541c3d14024093263..4214c9e843514d97d8f1eca7f34c169a2d3a19ca 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-19  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: Remove unused _pendingFilter from NetworkTableContentView
>+        https://bugs.webkit.org/show_bug.cgi?id=199026
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This flag is no longer set as of https://trac.webkit.org/changeset/225895.
>+
>+        * UserInterface/Views/NetworkTableContentView.js:
>+        (WI.NetworkTableContentView):
>+        (WI.NetworkTableContentView.prototype._processPendingEntries):
>+
> 2019-06-13  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: REGRESSION(r246178): extra spaces added in at-rules when formatting CSS
>diff --git a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>index cffd1cf284c59a1fcd70310836d5eda86fb3532a..bdd4c837e8e3a73a59bc58368a3193e005b94fb2 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>@@ -39,7 +39,6 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
> 
>         this._entriesSortComparator = null;
> 
>-        this._pendingFilter = false;
>         this._showingRepresentedObjectCookie = null;
> 
>         this._table = null;
>@@ -1333,10 +1332,9 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
>     {
>         let collection = this._activeCollection;
>         let needsSort = collection.pendingUpdates.length > 0;
>-        let needsFilter = this._pendingFilter;
> 
>-        // No global sort or filter is needed, so just insert new records into their sorted position.
>-        if (!needsSort && !needsFilter) {
>+        // No global sort is needed, so just insert new records into their sorted position.
>+        if (!needsSort) {
>             let originalLength = collection.pendingInsertions.length;
>             for (let resource of collection.pendingInsertions)
>                 this._insertResourceAndReloadTable(resource);
>@@ -1358,8 +1356,6 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
>         }
>         collection.pendingUpdates = [];
> 
>-        this._pendingFilter = false;
>-
>         this._updateSort();
>         this._updateFilteredEntries();
>         this._reloadTable();

Actions: View | Formatted Diff | Diff

Attachments on bug 199026: 372486