Attachment 372480 Details for Bug 199019 – Patch

[patch] Patch

bug-199019-20190619111717.patch (text/plain), 1.41 KB, created by Devin Rousso on 2019-06-19 11:17:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-19 11:17:18 PDT

Size: 1.41 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index abcf04b8ebe2125d37f2aced2946b1f61336384b..b6fd85bdde68b8d54e46c334d950267e6987f1df 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-19  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'sourceCodePosition.lineNumber')
>+        https://bugs.webkit.org/show_bug.cgi?id=199019
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Base/Main.js:
>+        (WI.linkifyLocation):
>+
> 2019-06-18  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Network: detail view shouldn't stay open when the related entry is removed
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Main.js b/Source/WebInspectorUI/UserInterface/Base/Main.js
>index 04047f5b99c7273a55e0e6d9b0e11b9a86cc3a79..5fd8112dd05380744368c2aa6c747b1f3b0f1bee 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Main.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Main.js
>@@ -2850,7 +2850,7 @@ WI.linkifyLocation = function(url, sourceCodePosition, options = {})
> {
>     var sourceCode = WI.sourceCodeForURL(url);
>     if (sourceCode)
>-        return WI.linkifySourceCode(sourceCode);
>+        return WI.linkifySourceCode(sourceCode, sourceCodePosition, options);
> 
>     var anchor = document.createElement("a");
>     anchor.href = url;

Actions: View | Formatted Diff | Diff

Attachments on bug 199019: 372480