Attachment 372450 Details for Bug 198666 – Patch

[patch] Patch

bug-198666-20190619175030.patch (text/plain), 1.98 KB, created by cathiechen on 2019-06-19 02:50:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: cathiechen

Created: 2019-06-19 02:50:32 PDT

Size: 1.98 KB

patch

obsolete

>Subversion Revision: 246579
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 6f70302e5af793e8076788935698ed616de536d0..c1cddedf06c07ee04810a01ad183e573c4ad85b5 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-19  Cathie Chen  <cathiechen@igalia.com>
>+
>+        resize-observer/element-leak.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=198666
>+
>+        Reviewed by FrÃ©dÃ©ric Wang.
>+
>+        It takes a very long time to construct iframes which create and remove 1000 elements. This would cause timeout sometimes.
>+        In order to make it more effective, reduce the number of elements to 200 and put them into a container first,
>+        then attach the container to DOM tree.
>+
>+        * resize-observer/resources/element-leak-frame.html:
>+
> 2019-06-18  Saam Barati  <sbarati@apple.com>
> 
>         [WHLSL] Support matrices
>diff --git a/LayoutTests/resize-observer/resources/element-leak-frame.html b/LayoutTests/resize-observer/resources/element-leak-frame.html
>index b162d44d424f3a009bb8f31ee350cd48504f4e10..3fe5f397cd27da2feee0c827f2702d9a240202cf 100644
>--- a/LayoutTests/resize-observer/resources/element-leak-frame.html
>+++ b/LayoutTests/resize-observer/resources/element-leak-frame.html
>@@ -3,7 +3,7 @@
> <script src="../../resources/gc.js"></script>
> <script type="text/javascript">
> 
>-const targetCount = 1000;
>+const targetCount = 200;
> var resizeObserver = new ResizeObserver( entries => {
>     for (let entry of entries)
>         entry.target.myEntry = entry;
>@@ -15,10 +15,12 @@ var resizeObserver = new ResizeObserver( entries => {
>     parent.postMessage('Notified', '*');
> });
> 
>+var container = document.createElement('div');
> for (let i = 0; i < targetCount; ++i) {
>     var target = document.createElement('div');
>-    document.body.appendChild(target);
>+    container.appendChild(target);
> }
>+document.body.appendChild(container);
> 
> document.querySelectorAll('div').forEach(target => resizeObserver.observe(target));
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198666: 371636 | 371647 | 371649 | 372449 | 372450