Attachment 372412 Details for Bug 198956 – Patch

[patch] Patch

bug-198956-20190618173348.patch (text/plain), 39.15 KB, created by Devin Rousso on 2019-06-18 17:33:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-18 17:33:49 PDT

Size: 39.15 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2d2087b45b95cf344e6a9aeb5f786eb73dd590fe..5ccff57633a2d7c0b03f5209edbac6d67230388b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-06-18  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
>+        https://bugs.webkit.org/show_bug.cgi?id=198956
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * inspector/InspectorFrontendClient.h:
>+
>+        * inspector/InspectorFrontendClientLocal.h:
>+        * inspector/InspectorFrontendClientLocal.cpp:
>+        (WebCore::InspectorFrontendClientLocal::Settings::deleteProperty): Added.
>+        (WebCore::InspectorFrontendClientLocal::resetWindowState): Added.
>+
>+        * inspector/InspectorFrontendHost.idl:
>+        * inspector/InspectorFrontendHost.h:
>+        * inspector/InspectorFrontendHost.cpp:
>+        (WebCore::InspectorFrontendHost::reset): Added.
>+
> 2019-06-18  Kenneth Russell  <kbr@chromium.org>
> 
>         Add preliminary ANGLE backend to WebCore
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index abcf04b8ebe2125d37f2aced2946b1f61336384b..7b2ab7782b4091424860e0066c31c631746fcee4 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-18  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
>+        https://bugs.webkit.org/show_bug.cgi?id=198956
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Base/Main.js:
>+        (WI.reset): Added.
>+
>+        * UserInterface/Views/SettingsTabContentView.js:
>+        (WI.SettingsTabContentView.prototype._createDebugSettingsView):
>+
> 2019-06-18  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Network: detail view shouldn't stay open when the related entry is removed
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3371ccfc311e6d83adb40c0804628c8b82ce54fd..8e8851c51f0f5692608a1dd2ebc0c5764e14bb80 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,57 @@
>+2019-06-18  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
>+        https://bugs.webkit.org/show_bug.cgi?id=198956
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/WebPreferences.h:
>+        * UIProcess/WebPreferences.cpp:
>+        (WebKit::WebPreferences::deleteKey): Added.
>+        * UIProcess/gtk/WebPreferencesGtk.cpp:
>+        (WebKit::WebPreferences::platformDeleteKey): Added.
>+        * UIProcess/mac/WebPreferencesMac.mm:
>+        (WebKit::WebPreferences::platformDeleteKey): Added.
>+        * UIProcess/wpe/WebPreferencesWPE.cpp:
>+        (WebKit::WebPreferences::platformDeleteKey): Added.
>+        * UIProcess/win/WebPreferencesWin.cpp:
>+        (WebKit::WebPreferences::platformDeleteKey): Added.
>+        * Shared/WebPreferencesStore.h:
>+        * Shared/WebPreferencesStore.cpp:
>+        (WebKit::WebPreferencesStore::deleteKey): Added.
>+
>+        * UIProcess/WebInspectorProxy.messages.in:
>+        * UIProcess/WebInspectorProxy.h:
>+        * UIProcess/WebInspectorProxy.cpp:
>+        (WebKit::WebInspectorProxy::resetWindowState): Added.
>+        (WebKit::WebInspectorProxy::platformResetWindowState): Added.
>+        * UIProcess/gtk/WebInspectorProxyGtk.cpp:
>+        (WebKit::WebInspectorProxy::platformResetWindowState): Added.
>+        * UIProcess/mac/WebInspectorProxyMac.mm:
>+        (WebKit::WebInspectorProxy::platformResetWindowState): Added.
>+        * UIProcess/wpe/WebInspectorProxyWPE.cpp:
>+        (WebKit::WebInspectorProxy::platformResetWindowState): Added.
>+        * UIProcess/win/WebInspectorProxyWin.cpp:
>+        (WebKit::WebInspectorProxy::platformResetWindowState): Added.
>+        * WebProcess/WebPage/WebInspectorUI.h:
>+        * WebProcess/WebPage/WebInspectorUI.cpp:
>+        (WebKit::WebInspectorUI::resetWindowState): Added.
>+
>+        * UIProcess/RemoteWebInspectorProxy.messages.in:
>+        * UIProcess/RemoteWebInspectorProxy.h:
>+        * UIProcess/RemoteWebInspectorProxy.cpp:
>+        (WebKit::RemoteWebInspectorProxy::resetWindowState): Added.
>+        (WebKit::RemoteWebInspectorProxy::platformResetWindowState): Added.
>+        * UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp:
>+        (WebKit::RemoteWebInspectorProxy::platformResetWindowState): Added.
>+        * UIProcess/mac/RemoteWebInspectorProxyMac.mm:
>+        (WebKit::RemoteWebInspectorProxy::platformResetWindowState): Added.
>+        * UIProcess/win/RemoteWebInspectorProxyWin.cpp:
>+        (WebKit::RemoteWebInspectorProxy::platformResetWindowState): Added.
>+        * WebProcess/WebPage/RemoteWebInspectorUI.h:
>+        * WebProcess/WebPage/RemoteWebInspectorUI.cpp:
>+        (WebKit::RemoteWebInspectorUI::resetWindowState): Added.
>+
> 2019-06-18  John Wilander  <wilander@apple.com>
> 
>         Change log channel name from ResourceLoadStatisticsDebug to ITPDebug and remove unnecessary #if !RELEASE_LOG_DISABLED
>diff --git a/Source/WebKitLegacy/cf/ChangeLog b/Source/WebKitLegacy/cf/ChangeLog
>index 92a1f05e9072d33689c063891af93fece0309709..498c53d479f59fc012eca2e9f5b524a90000d029 100644
>--- a/Source/WebKitLegacy/cf/ChangeLog
>+++ b/Source/WebKitLegacy/cf/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-18  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
>+        https://bugs.webkit.org/show_bug.cgi?id=198956
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebCoreSupport/WebInspectorClientCF.cpp:
>+        (deleteSetting): Added.
>+        (WebInspectorClient::deleteInspectorStartsAttached): Added.
>+        (WebInspectorClient::deleteInspectorAttachDisabled): Added.
>+        (WebInspectorClient::createFrontendSettings):
>+
> 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
> 
>         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
>diff --git a/Source/WebKitLegacy/ios/ChangeLog b/Source/WebKitLegacy/ios/ChangeLog
>index b63f7771438f871758818c9ff66c032b60c944e8..50524123974cc505e1db4122a721b8f058284079 100644
>--- a/Source/WebKitLegacy/ios/ChangeLog
>+++ b/Source/WebKitLegacy/ios/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-18  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
>+        https://bugs.webkit.org/show_bug.cgi?id=198956
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebCoreSupport/WebInspectorClientIOS.mm:
>+        (WebInspectorFrontendClient::resetWindowState): Added.
>+
> 2019-06-16  Darin Adler  <darin@apple.com>
> 
>         Rename AtomicString to AtomString
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index fe432d064602893b2c6162a9522b188fbe245d8b..cb1dccf4844ed7e43cf08fbdfe63e80816ae8bdb 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-18  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
>+        https://bugs.webkit.org/show_bug.cgi?id=198956
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebCoreSupport/WebInspectorClient.h:
>+        * WebCoreSupport/WebInspectorClient.mm:
>+        (WebInspectorFrontendClient::resetWindowState): Added.
>+
> 2019-06-16  Darin Adler  <darin@apple.com>
> 
>         Rename AtomicString to AtomString
>diff --git a/Source/WebKitLegacy/win/ChangeLog b/Source/WebKitLegacy/win/ChangeLog
>index 601d76234ce6486282d5dd8801c2a891d711b722..16349cbac194eb8a22258002d6acda75d51a93bf 100644
>--- a/Source/WebKitLegacy/win/ChangeLog
>+++ b/Source/WebKitLegacy/win/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-18  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
>+        https://bugs.webkit.org/show_bug.cgi?id=198956
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebCoreSupport/WebInspectorClient.h:
>+        * WebCoreSupport/WebInspectorClient.cpp:
>+        (WebInspectorFrontendClient::resetWindowState): Added.
>+
> 2019-06-16  Darin Adler  <darin@apple.com>
> 
>         Rename AtomicString to AtomString
>diff --git a/Source/WebCore/inspector/InspectorFrontendClient.h b/Source/WebCore/inspector/InspectorFrontendClient.h
>index 00ce825fdf15e7c6b353e1e5468936498a8fbf4a..7cf3c2a6fed9c6a7d3f7d09d52b73b8229f5736d 100644
>--- a/Source/WebCore/inspector/InspectorFrontendClient.h
>+++ b/Source/WebCore/inspector/InspectorFrontendClient.h
>@@ -65,6 +65,7 @@ public:
>     virtual void bringToFront() = 0;
>     virtual void closeWindow() = 0;
>     virtual void reopen() = 0;
>+    virtual void resetState() = 0;
> 
>     virtual UserInterfaceLayoutDirection userInterfaceLayoutDirection() const = 0;
> 
>diff --git a/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp b/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp
>index ea6af54ee90247b6fa900c205ea17aed1e80a92b..a4e21542ec2cc9f92c74ac5146fbb2ef327fdee7 100644
>--- a/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp
>+++ b/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp
>@@ -127,6 +127,10 @@ void InspectorFrontendClientLocal::Settings::setProperty(const String&, const St
> {
> }
> 
>+void InspectorFrontendClientLocal::Settings::deleteProperty(const String&)
>+{
>+}
>+
> InspectorFrontendClientLocal::InspectorFrontendClientLocal(InspectorController* inspectedPageController, Page* frontendPage, std::unique_ptr<Settings> settings)
>     : m_inspectedPageController(inspectedPageController)
>     , m_frontendPage(frontendPage)
>@@ -146,6 +150,11 @@ InspectorFrontendClientLocal::~InspectorFrontendClientLocal()
>     m_dispatchTask->reset();
> }
> 
>+void InspectorFrontendClientLocal::resetState()
>+{
>+    m_settings->deleteProperty(inspectorAttachedHeightSetting);
>+}
>+
> void InspectorFrontendClientLocal::windowObjectCleared()
> {
>     if (m_frontendHost)
>diff --git a/Source/WebCore/inspector/InspectorFrontendClientLocal.h b/Source/WebCore/inspector/InspectorFrontendClientLocal.h
>index ae26ccae9ca99c5d5c2ae6e49667aea8867b1d96..ce3b7075f08a6d93b9340708ce65d3844bf188a0 100644
>--- a/Source/WebCore/inspector/InspectorFrontendClientLocal.h
>+++ b/Source/WebCore/inspector/InspectorFrontendClientLocal.h
>@@ -55,11 +55,14 @@ public:
>         virtual ~Settings() = default;
>         virtual String getProperty(const String& name);
>         virtual void setProperty(const String& name, const String& value);
>+        virtual void deleteProperty(const String& name);
>     };
> 
>     WEBCORE_EXPORT InspectorFrontendClientLocal(InspectorController* inspectedPageController, Page* frontendPage, std::unique_ptr<Settings>);
>     WEBCORE_EXPORT virtual ~InspectorFrontendClientLocal();
> 
>+    WEBCORE_EXPORT void resetState() override;
>+
>     WEBCORE_EXPORT void windowObjectCleared() final;
>     WEBCORE_EXPORT void frontendLoaded() override;
> 
>diff --git a/Source/WebCore/inspector/InspectorFrontendHost.cpp b/Source/WebCore/inspector/InspectorFrontendHost.cpp
>index 71ca44bffd460a0fd2f22fdef9e679b39a1b8757..9fa6ab11b53f2ef0431ef90c36387897fc6a5f2e 100644
>--- a/Source/WebCore/inspector/InspectorFrontendHost.cpp
>+++ b/Source/WebCore/inspector/InspectorFrontendHost.cpp
>@@ -197,6 +197,13 @@ void InspectorFrontendHost::reopen()
>         m_client->reopen();
> }
> 
>+void InspectorFrontendHost::reset()
>+{
>+    if (m_client)
>+        m_client->resetState();
>+    reopen();
>+}
>+
> void InspectorFrontendHost::bringToFront()
> {
>     if (m_client)
>diff --git a/Source/WebCore/inspector/InspectorFrontendHost.h b/Source/WebCore/inspector/InspectorFrontendHost.h
>index 3017cb76c09e5d27ee416ed5c9bc47d3b0ecdcab..56b89df622bcc7d534afcfe490cd3eace0a3bd45 100644
>--- a/Source/WebCore/inspector/InspectorFrontendHost.h
>+++ b/Source/WebCore/inspector/InspectorFrontendHost.h
>@@ -55,9 +55,10 @@ public:
>     WEBCORE_EXPORT void addSelfToGlobalObjectInWorld(DOMWrapperWorld&);
> 
>     void loaded();
>-    void requestSetDockSide(const String&);
>     void closeWindow();
>     void reopen();
>+    void reset();
>+
>     void bringToFront();
>     void inspectedURLChanged(const String&);
> 
>@@ -69,6 +70,8 @@ public:
> 
>     String userInterfaceLayoutDirection();
> 
>+    void requestSetDockSide(const String&);
>+
>     void setAttachedWindowHeight(unsigned);
>     void setAttachedWindowWidth(unsigned);
> 
>diff --git a/Source/WebCore/inspector/InspectorFrontendHost.idl b/Source/WebCore/inspector/InspectorFrontendHost.idl
>index 023a39cbc8f0884e390b29822d19bdaffa912992..90b3afcdd91706c5ab937ac306cced2fc4e42c56 100644
>--- a/Source/WebCore/inspector/InspectorFrontendHost.idl
>+++ b/Source/WebCore/inspector/InspectorFrontendHost.idl
>@@ -37,6 +37,8 @@
>     void loaded();
>     void closeWindow();
>     void reopen();
>+    void reset();
>+
>     void bringToFront();
>     void inspectedURLChanged(DOMString newURL);
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Main.js b/Source/WebInspectorUI/UserInterface/Base/Main.js
>index 04047f5b99c7273a55e0e6d9b0e11b9a86cc3a79..057f2d236d049be6c2a5f8e1b4bafdb714e7aebd 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Main.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Main.js
>@@ -3226,6 +3226,13 @@ WI.assumingMainTarget = function()
>     return WI.mainTarget;
> };
> 
>+WI.reset = async function()
>+{
>+    await WI.ObjectStore.reset();
>+    WI.Setting.reset();
>+    InspectorFrontendHost.reset();
>+};
>+
> WI.isEngineeringBuild = false;
> 
> // OpenResourceDialog delegate
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>index 14aadeddc05d8b6d930e0adf5e205730161ffb90..53fd2c7fcb5e189bd647564dfed1716270bac0c5 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>@@ -392,10 +392,8 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi
> 
>         let resetInspectorButton = document.createElement("button");
>         resetInspectorButton.textContent = WI.unlocalizedString("Reset Web Inspector");
>-        resetInspectorButton.addEventListener("click", async (event) => {
>-            await WI.ObjectStore.reset();
>-            WI.Setting.reset();
>-            InspectorFrontendHost.reopen();
>+        resetInspectorButton.addEventListener("click", (event) => {
>+            WI.reset();
>         });
>         this._debugSettingsView.addCenteredContainer(resetInspectorButton);
> 
>diff --git a/Source/WebKit/Shared/WebPreferencesStore.cpp b/Source/WebKit/Shared/WebPreferencesStore.cpp
>index 503628e9e3487ef6475f45f89b9cd698e7e002dd..bbcee41699c0d5f84dc6c792ab644c6fdd81d0d7 100644
>--- a/Source/WebKit/Shared/WebPreferencesStore.cpp
>+++ b/Source/WebKit/Shared/WebPreferencesStore.cpp
>@@ -173,4 +173,10 @@ void WebPreferencesStore::setOverrideDefaultsDoubleValueForKey(const String& key
>     m_overriddenDefaults.set(key, Value(value));
> }
> 
>+void WebPreferencesStore::deleteKey(const String& key)
>+{
>+    m_values.remove(key);
>+    m_overriddenDefaults.remove(key);
>+}
>+
> } // namespace WebKit
>diff --git a/Source/WebKit/Shared/WebPreferencesStore.h b/Source/WebKit/Shared/WebPreferencesStore.h
>index 4b39686dee8df73dbb49a6f7dcf68d8ffa8b3395..8a4a0bf3281761edc8767800f1af5e22bfbe7905 100644
>--- a/Source/WebKit/Shared/WebPreferencesStore.h
>+++ b/Source/WebKit/Shared/WebPreferencesStore.h
>@@ -58,6 +58,8 @@ struct WebPreferencesStore {
>     void setOverrideDefaultsUInt32ValueForKey(const String& key, uint32_t value);
>     void setOverrideDefaultsDoubleValueForKey(const String& key, double value);
> 
>+    void deleteKey(const String& key);
>+
>     // For WebKitTestRunner usage.
>     static void overrideBoolValueForKey(const String& key, bool value);
>     static void removeTestRunnerOverrides();
>diff --git a/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp b/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp
>index 6679d45bd9969204afcf5bb2f4e9a48e6164389d..4aa344490d8e319998407d3cf2ae47d03e672d33 100644
>--- a/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp
>+++ b/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp
>@@ -102,6 +102,11 @@ void RemoteWebInspectorProxy::reopen()
>     load(m_debuggableType, m_backendCommandsURL);
> }
> 
>+void RemoteWebInspectorProxy::resetState()
>+{
>+    platformResetState();
>+}
>+
> void RemoteWebInspectorProxy::bringToFront()
> {
>     platformBringToFront();
>@@ -177,6 +182,7 @@ WebPageProxy* RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow()
>     return nullptr;
> }
> 
>+void RemoteWebInspectorProxy::platformResetState() { }
> void RemoteWebInspectorProxy::platformBringToFront() { }
> void RemoteWebInspectorProxy::platformSave(const String&, const String&, bool, bool) { }
> void RemoteWebInspectorProxy::platformAppend(const String&, const String&) { }
>diff --git a/Source/WebKit/UIProcess/RemoteWebInspectorProxy.h b/Source/WebKit/UIProcess/RemoteWebInspectorProxy.h
>index 5ebbb68d4c6daa33c2858bd7ae0953104abc14ee..58029939d906037b3b8703f3158c3e1683dc5da2 100644
>--- a/Source/WebKit/UIProcess/RemoteWebInspectorProxy.h
>+++ b/Source/WebKit/UIProcess/RemoteWebInspectorProxy.h
>@@ -107,6 +107,7 @@ private:
>     // RemoteWebInspectorProxy messages.
>     void frontendDidClose();
>     void reopen();
>+    void resetState();
>     void bringToFront();
>     void save(const String& filename, const String& content, bool base64Encoded, bool forceSaveAs);
>     void append(const String& filename, const String& content);
>@@ -122,6 +123,7 @@ private:
>     // Platform implementations.
>     WebPageProxy* platformCreateFrontendPageAndWindow();
>     void platformCloseFrontendPageAndWindow();
>+    void platformResetState();
>     void platformBringToFront();
>     void platformSave(const String& filename, const String& content, bool base64Encoded, bool forceSaveAs);
>     void platformAppend(const String& filename, const String& content);
>diff --git a/Source/WebKit/UIProcess/RemoteWebInspectorProxy.messages.in b/Source/WebKit/UIProcess/RemoteWebInspectorProxy.messages.in
>index b787235ed80d60472e36c5a800a9bd1b8565fe8e..be091b78fb6a8d5df7b23e050ffff1d92a4bd4b1 100644
>--- a/Source/WebKit/UIProcess/RemoteWebInspectorProxy.messages.in
>+++ b/Source/WebKit/UIProcess/RemoteWebInspectorProxy.messages.in
>@@ -23,6 +23,7 @@
> messages -> RemoteWebInspectorProxy {
>     FrontendDidClose()
>     Reopen()
>+    ResetState()
>     BringToFront()
> 
>     Save(String filename, String content, bool base64Encoded, bool forceSaveAs)
>diff --git a/Source/WebKit/UIProcess/WebInspectorProxy.cpp b/Source/WebKit/UIProcess/WebInspectorProxy.cpp
>index 12bb261d07c287b034a6afc1648cfad60e3fb2da..6bbf85bbdaf299dd7ecf858717f9d71f2d099bf1 100644
>--- a/Source/WebKit/UIProcess/WebInspectorProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebInspectorProxy.cpp
>@@ -182,6 +182,17 @@ void WebInspectorProxy::reopen()
>     show();
> }
> 
>+void WebInspectorProxy::resetState()
>+{
>+    inspectorPagePreferences().deleteInspectorAttachedHeight();
>+    inspectorPagePreferences().deleteInspectorAttachedWidth();
>+    inspectorPagePreferences().deleteInspectorAttachmentSide();
>+    inspectorPagePreferences().deleteInspectorStartsAttached();
>+    inspectorPagePreferences().deleteInspectorWindowFrame();
>+
>+    platformResetState();
>+}
>+
> void WebInspectorProxy::reset()
> {
>     if (m_inspectedPage) {
>@@ -626,6 +637,11 @@ void WebInspectorProxy::platformInvalidate()
>     notImplemented();
> }
> 
>+void WebInspectorProxy::platformResetState()
>+{
>+    notImplemented();
>+}
>+
> void WebInspectorProxy::platformBringToFront()
> {
>     notImplemented();
>diff --git a/Source/WebKit/UIProcess/WebInspectorProxy.h b/Source/WebKit/UIProcess/WebInspectorProxy.h
>index 6aaeb81de632ebfbac7d776114818716e82a6015..8be27d46db455f1290dc7d556e3c5fe1b372e048 100644
>--- a/Source/WebKit/UIProcess/WebInspectorProxy.h
>+++ b/Source/WebKit/UIProcess/WebInspectorProxy.h
>@@ -101,6 +101,7 @@ public:
>     void close();
>     void closeForCrash();
>     void reopen();
>+    void resetState();
> 
>     void reset();
>     void updateForNewPageProcess(WebPageProxy*);
>@@ -189,6 +190,7 @@ private:
> 
>     void platformDidCloseForCrash();
>     void platformInvalidate();
>+    void platformResetState();
>     void platformBringToFront();
>     void platformBringInspectedPageToFront();
>     void platformHide();
>diff --git a/Source/WebKit/UIProcess/WebInspectorProxy.messages.in b/Source/WebKit/UIProcess/WebInspectorProxy.messages.in
>index 1284bd4a752e27643bdeef3dcfd4dacea1032083..7d4a99d396ab116b753b4f6e7059b799ed198044 100644
>--- a/Source/WebKit/UIProcess/WebInspectorProxy.messages.in
>+++ b/Source/WebKit/UIProcess/WebInspectorProxy.messages.in
>@@ -30,6 +30,7 @@ messages -> WebInspectorProxy {
>     DidClose()
>     BringToFront()
>     Reopen()
>+    ResetState()
> 
>     InspectedURLChanged(String urlString)
>     ShowCertificate(WebCore::CertificateInfo certificateInfo)
>diff --git a/Source/WebKit/UIProcess/WebPreferences.cpp b/Source/WebKit/UIProcess/WebPreferences.cpp
>index 7002db2064cf6751d9b19e358b5460a92f2820f5..aa1a2170d458b6bb47a2f2b47d67b6242c77ad4c 100644
>--- a/Source/WebKit/UIProcess/WebPreferences.cpp
>+++ b/Source/WebKit/UIProcess/WebPreferences.cpp
>@@ -178,6 +178,13 @@ void WebPreferences::updateFloatValueForKey(const String& key, float value)
>     update(); // FIXME: Only send over the changed key and value.
> }
> 
>+void WebPreferences::deleteKey(const String& key)
>+{
>+    m_store.deleteKey(key);
>+    platformDeleteKey(key);
>+    update(); // FIXME: Only send over the changed key and value.
>+}
>+
> void WebPreferences::updatePrivateBrowsingValue(bool value)
> {
>     platformUpdateBoolValueForKey(WebPreferencesKey::privateBrowsingEnabledKey(), value);
>@@ -208,7 +215,11 @@ void WebPreferences::updatePrivateBrowsingValue(bool value)
>         if (!m_store.set##TypeName##ValueForKey(WebPreferencesKey::KeyLower##Key(), value)) \
>             return; \
>         update##TypeName##ValueForKey(WebPreferencesKey::KeyLower##Key(), value); \
>-        \
>+    } \
>+    \
>+    void WebPreferences::delete##KeyUpper() \
>+    { \
>+        deleteKey(WebPreferencesKey::KeyLower##Key()); \
>     } \
>     \
>     Type WebPreferences::KeyLower() const \
>diff --git a/Source/WebKit/UIProcess/WebPreferences.h b/Source/WebKit/UIProcess/WebPreferences.h
>index 317f740afe19f30801bce720cdb64b57d1da66b0..12061f62a1d012619c6c222d8bfd3909d5424753 100644
>--- a/Source/WebKit/UIProcess/WebPreferences.h
>+++ b/Source/WebKit/UIProcess/WebPreferences.h
>@@ -35,6 +35,7 @@
> 
> #define DECLARE_PREFERENCE_GETTER_AND_SETTERS(KeyUpper, KeyLower, TypeName, Type, DefaultValue, HumanReadableName, HumanReadableDescription) \
>     void set##KeyUpper(const Type& value); \
>+    void delete##KeyUpper(); \
>     Type KeyLower() const;
> 
> namespace WebKit {
>@@ -98,6 +99,9 @@ private:
>     void platformUpdateDoubleValueForKey(const String& key, double value);
>     void platformUpdateFloatValueForKey(const String& key, float value);
> 
>+    void deleteKey(const String& key);
>+    void platformDeleteKey(const String& key);
>+
>     void updatePrivateBrowsingValue(bool value);
> 
>     void registerDefaultBoolValueForKey(const String&, bool);
>diff --git a/Source/WebKit/UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp b/Source/WebKit/UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp
>index c1ac043b33046d157506d065613ea7cecd004b70..796655cef17251024fb691623153b6fb722298a2 100644
>--- a/Source/WebKit/UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp
>+++ b/Source/WebKit/UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp
>@@ -89,6 +89,10 @@ void RemoteWebInspectorProxy::platformCloseFrontendPageAndWindow()
>         gtk_widget_destroy(m_window);
> }
> 
>+void RemoteWebInspectorProxy::platformResetState()
>+{
>+}
>+
> void RemoteWebInspectorProxy::platformBringToFront()
> {
>     if (m_window)
>diff --git a/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp b/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp
>index 28c2078fa8abb770b13605f90e8f62c1e318b89c..852719814110bd6a7185e9af7b71fdfda61193fe 100644
>--- a/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp
>+++ b/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp
>@@ -302,6 +302,10 @@ void WebInspectorProxy::platformHide()
>     notImplemented();
> }
> 
>+void WebInspectorProxy::platformResetState()
>+{
>+}
>+
> void WebInspectorProxy::platformBringToFront()
> {
>     if (m_isOpening)
>diff --git a/Source/WebKit/UIProcess/gtk/WebPreferencesGtk.cpp b/Source/WebKit/UIProcess/gtk/WebPreferencesGtk.cpp
>index eca423b71a23c39cbf343ecb8e6fa39b70c54dc6..9847f9625ef417e98fe002fabbd560dde3de17d0 100644
>--- a/Source/WebKit/UIProcess/gtk/WebPreferencesGtk.cpp
>+++ b/Source/WebKit/UIProcess/gtk/WebPreferencesGtk.cpp
>@@ -65,6 +65,11 @@ void WebPreferences::platformUpdateFloatValueForKey(const String&, float)
>     notImplemented();
> }
> 
>+void WebPreferences::platformDeleteKey(const String&)
>+{
>+    notImplemented();
>+}
>+
> bool WebPreferences::platformGetStringUserValueForKey(const String&, String&)
> {
>     notImplemented();
>diff --git a/Source/WebKit/UIProcess/mac/RemoteWebInspectorProxyMac.mm b/Source/WebKit/UIProcess/mac/RemoteWebInspectorProxyMac.mm
>index 760a1d009de23c6c2b558a5fd3e1a53b5bc38573..349ced3e180d56a862fc967e50927fff47bd2c13 100644
>--- a/Source/WebKit/UIProcess/mac/RemoteWebInspectorProxyMac.mm
>+++ b/Source/WebKit/UIProcess/mac/RemoteWebInspectorProxyMac.mm
>@@ -123,6 +123,11 @@ void RemoteWebInspectorProxy::platformCloseFrontendPageAndWindow()
>         m_objCAdapter = nil;
> }
> 
>+void RemoteWebInspectorProxy::platformResetState()
>+{
>+    [NSWindow removeFrameUsingName:[m_window frameAutosaveName]];
>+}
>+
> void RemoteWebInspectorProxy::platformBringToFront()
> {
>     [m_window makeKeyAndOrderFront:nil];
>diff --git a/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm b/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm
>index 007d87dfcd84ca9686218352c8f8fd0c12fc77cd..29c6140b209267c65aa830bd09942ce5dc3399cf 100644
>--- a/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm
>+++ b/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm
>@@ -361,6 +361,11 @@ void WebInspectorProxy::platformHide()
>     }
> }
> 
>+void WebInspectorProxy::platformResetState()
>+{
>+    inspectedPage()->pageGroup().preferences().deleteInspectorWindowFrame();
>+}
>+
> void WebInspectorProxy::platformBringToFront()
> {
>     // If the Web Inspector is no longer in the same window as the inspected view,
>diff --git a/Source/WebKit/UIProcess/mac/WebPreferencesMac.mm b/Source/WebKit/UIProcess/mac/WebPreferencesMac.mm
>index abe295cc0b4ff7af986c02e4125b225e73c4cae4..ab4ad00b26bdb917ca3b12355eb990f1ea458b15 100644
>--- a/Source/WebKit/UIProcess/mac/WebPreferencesMac.mm
>+++ b/Source/WebKit/UIProcess/mac/WebPreferencesMac.mm
>@@ -198,4 +198,12 @@ void WebPreferences::platformUpdateFloatValueForKey(const String& key, float val
>     [[NSUserDefaults standardUserDefaults] setFloat:value forKey:makeKey(m_identifier, m_keyPrefix, key)];
> }
> 
>+void WebPreferences::platformDeleteKey(const String& key)
>+{
>+    if (!m_identifier)
>+        return;
>+
>+    [[NSUserDefaults standardUserDefaults] removeObjectForKey:makeKey(m_identifier, m_keyPrefix, key)];
>+}
>+
> } // namespace WebKit
>diff --git a/Source/WebKit/UIProcess/win/RemoteWebInspectorProxyWin.cpp b/Source/WebKit/UIProcess/win/RemoteWebInspectorProxyWin.cpp
>index 0da1e5387416bb0a8229c87035c8864237aa5ae8..390c2b94f2ff54a4f0da9eaee40108c99eaa0bbc 100644
>--- a/Source/WebKit/UIProcess/win/RemoteWebInspectorProxyWin.cpp
>+++ b/Source/WebKit/UIProcess/win/RemoteWebInspectorProxyWin.cpp
>@@ -129,6 +129,7 @@ WebPageProxy* RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow()
>     return m_webView->page();
> }
> 
>+void RemoteWebInspectorProxy::platformResetState() { }
> void RemoteWebInspectorProxy::platformBringToFront() { }
> void RemoteWebInspectorProxy::platformSave(const String&, const String&, bool, bool) { }
> void RemoteWebInspectorProxy::platformAppend(const String&, const String&) { }
>diff --git a/Source/WebKit/UIProcess/win/WebInspectorProxyWin.cpp b/Source/WebKit/UIProcess/win/WebInspectorProxyWin.cpp
>index a7fcce10997972ac45221f227ba74c11e02b20fc..4e30ef4dff657b1038ed215a6a72ecfc0965ee1f 100644
>--- a/Source/WebKit/UIProcess/win/WebInspectorProxyWin.cpp
>+++ b/Source/WebKit/UIProcess/win/WebInspectorProxyWin.cpp
>@@ -374,6 +374,11 @@ void WebInspectorProxy::platformHide()
>     notImplemented();
> }
> 
>+void WebInspectorProxy::platformResetState()
>+{
>+    notImplemented();
>+}
>+
> void WebInspectorProxy::platformBringToFront()
> {
>     notImplemented();
>diff --git a/Source/WebKit/UIProcess/win/WebPreferencesWin.cpp b/Source/WebKit/UIProcess/win/WebPreferencesWin.cpp
>index a20c4db9e74e2f832e1120788842a1221ae03ac9..2d2bf4246684547dd5705e13b6198b3444ed2a3e 100644
>--- a/Source/WebKit/UIProcess/win/WebPreferencesWin.cpp
>+++ b/Source/WebKit/UIProcess/win/WebPreferencesWin.cpp
>@@ -61,6 +61,11 @@ void WebPreferences::platformUpdateFloatValueForKey(const String&, float)
>     notImplemented();
> }
> 
>+void WebPreferences::platformDeleteKey(const String&)
>+{
>+    notImplemented();
>+}
>+
> bool WebPreferences::platformGetStringUserValueForKey(const String&, String&)
> {
>     notImplemented();
>diff --git a/Source/WebKit/UIProcess/wpe/WebInspectorProxyWPE.cpp b/Source/WebKit/UIProcess/wpe/WebInspectorProxyWPE.cpp
>index 0f426563293dbf2ccdff646467a446b172be38f3..bfcbc4c962fc75c14dd1875fa7b8c19eadcbc3f2 100644
>--- a/Source/WebKit/UIProcess/wpe/WebInspectorProxyWPE.cpp
>+++ b/Source/WebKit/UIProcess/wpe/WebInspectorProxyWPE.cpp
>@@ -61,6 +61,11 @@ void WebInspectorProxy::platformHide()
>     notImplemented();
> }
> 
>+void WebInspectorProxy::platformResetState()
>+{
>+    notImplemented();
>+}
>+
> void WebInspectorProxy::platformBringToFront()
> {
>     notImplemented();
>diff --git a/Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp b/Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp
>index ff81fcda1cfbde1e05cf38c16c2144db9e0e277b..48f2b25942d88024c3df71712d6f9f1abbf015c9 100644
>--- a/Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp
>+++ b/Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp
>@@ -60,6 +60,11 @@ void WebPreferences::platformUpdateFloatValueForKey(const String&, float)
>     notImplemented();
> }
> 
>+void WebPreferences::platformDeleteKey(const String&)
>+{
>+    notImplemented();
>+}
>+
> bool WebPreferences::platformGetStringUserValueForKey(const String&, String&)
> {
>     notImplemented();
>diff --git a/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp b/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp
>index 05440456f41db1c4f0905b55edfa3841ff7c1fd1..d4b8b00fa4b67bee27d37e0b54e0c3b05df41875 100644
>--- a/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp
>@@ -139,6 +139,11 @@ void RemoteWebInspectorUI::reopen()
>     WebProcess::singleton().parentProcessConnection()->send(Messages::RemoteWebInspectorProxy::Reopen(), m_page.pageID());
> }
> 
>+void RemoteWebInspectorUI::resetState()
>+{
>+    WebProcess::singleton().parentProcessConnection()->send(Messages::RemoteWebInspectorProxy::ResetState(), m_page.pageID());
>+}
>+
> void RemoteWebInspectorUI::openInNewTab(const String& url)
> {
>     WebProcess::singleton().parentProcessConnection()->send(Messages::RemoteWebInspectorProxy::OpenInNewTab(url), m_page.pageID());
>diff --git a/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h b/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h
>index 6213110821ae814765ccde85abe1f81719a6c6f2..25529960c82ed8e685ba7fcd1fd0454aca104f09 100644
>--- a/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h
>+++ b/Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h
>@@ -70,6 +70,7 @@ public:
>     void bringToFront() override;
>     void closeWindow() override;
>     void reopen() override;
>+    void resetState() override;
> 
>     void openInNewTab(const String& url) override;
>     void save(const String& url, const String& content, bool base64Encoded, bool forceSaveAs) override;
>diff --git a/Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp b/Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp
>index bcff8e2a896ff02e825165278119bd1feb4621e2..6e242d9c00de02df2a5007cdaebf20de5a601c34 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp
>@@ -176,6 +176,11 @@ void WebInspectorUI::reopen()
>     WebProcess::singleton().parentProcessConnection()->send(Messages::WebInspectorProxy::Reopen(), m_inspectedPageIdentifier);
> }
> 
>+void WebInspectorUI::resetState()
>+{
>+    WebProcess::singleton().parentProcessConnection()->send(Messages::WebInspectorProxy::ResetState(), m_inspectedPageIdentifier);
>+}
>+
> WebCore::UserInterfaceLayoutDirection WebInspectorUI::userInterfaceLayoutDirection() const
> {
>     return m_page.corePage()->userInterfaceLayoutDirection();
>diff --git a/Source/WebKit/WebProcess/WebPage/WebInspectorUI.h b/Source/WebKit/WebProcess/WebPage/WebInspectorUI.h
>index 9424bfe1f26cfdc16907c781fef4d6d05c5ece29..8beb13f124948098535dfc74e2271f7feed25c9d 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebInspectorUI.h
>+++ b/Source/WebKit/WebProcess/WebPage/WebInspectorUI.h
>@@ -96,6 +96,7 @@ public:
>     void bringToFront() override;
>     void closeWindow() override;
>     void reopen() override;
>+    void resetState() override;
> 
>     WebCore::UserInterfaceLayoutDirection userInterfaceLayoutDirection() const override;
> 
>diff --git a/Source/WebKitLegacy/cf/WebCoreSupport/WebInspectorClientCF.cpp b/Source/WebKitLegacy/cf/WebCoreSupport/WebInspectorClientCF.cpp
>index 515bb9bd211e2381a128505253018db1164abe13..db292621a20fb1a9b677d47b8a8263d057ce2280 100644
>--- a/Source/WebKitLegacy/cf/WebCoreSupport/WebInspectorClientCF.cpp
>+++ b/Source/WebKitLegacy/cf/WebCoreSupport/WebInspectorClientCF.cpp
>@@ -89,6 +89,11 @@ static void storeSetting(const String& key, const String& setting)
>     CFPreferencesSetAppValue(createKeyForPreferences(key).get(), setting.createCFString().get(), kCFPreferencesCurrentApplication);
> }
> 
>+static void deleteSetting(const String& key)
>+{
>+    CFPreferencesSetAppValue(createKeyForPreferences(key).get(), NULL, kCFPreferencesCurrentApplication);
>+}
>+
> void WebInspectorClient::sendMessageToFrontend(const String& message)
> {
>     doDispatchMessageOnFrontendPage(m_frontendPage, message);
>@@ -108,6 +113,11 @@ void WebInspectorClient::setInspectorAttachDisabled(bool disabled)
>     storeSetting(inspectorAttachDisabledSetting, disabled ? "true" : "false");
> }
> 
>+void WebInspectorClient::deleteInspectorStartsAttached()
>+{
>+    deleteSetting(inspectorAttachDisabledSetting);
>+}
>+
> bool WebInspectorClient::inspectorStartsAttached()
> {
>     String value;
>@@ -122,6 +132,11 @@ void WebInspectorClient::setInspectorStartsAttached(bool attached)
>     storeSetting(inspectorStartsAttachedSetting, attached ? "true" : "false");
> }
> 
>+void WebInspectorClient::deleteInspectorAttachDisabled()
>+{
>+    deleteSetting(inspectorStartsAttachedSetting);
>+}
>+
> std::unique_ptr<WebCore::InspectorFrontendClientLocal::Settings> WebInspectorClient::createFrontendSettings()
> {
>     class InspectorFrontendSettingsCF : public WebCore::InspectorFrontendClientLocal::Settings {
>@@ -138,6 +153,11 @@ std::unique_ptr<WebCore::InspectorFrontendClientLocal::Settings> WebInspectorCli
>         {
>             storeSetting(name, value);
>         }
>+
>+        virtual void deleteProperty(const String& name)
>+        {
>+            deleteSetting(name);
>+        }
>     };
>     return std::make_unique<InspectorFrontendSettingsCF>();
> }
>diff --git a/Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm b/Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm
>index 07169805403668300435fd443b0293563874924f..5296f12edd164ead72962218564434158228987b 100644
>--- a/Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm
>+++ b/Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm
>@@ -127,6 +127,7 @@ String WebInspectorFrontendClient::localizedStringsURL() { return String(); }
> void WebInspectorFrontendClient::bringToFront() { }
> void WebInspectorFrontendClient::closeWindow() { }
> void WebInspectorFrontendClient::reopen() { }
>+void WebInspectorFrontendClient::resetState() { }
> void WebInspectorFrontendClient::attachWindow(DockSide) { }
> void WebInspectorFrontendClient::detachWindow() { }
> void WebInspectorFrontendClient::setAttachedWindowHeight(unsigned) { }
>diff --git a/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h b/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h
>index 4a25a6c963d41355ac53e6e7910f5264cb29bd1c..bd7f62fc85dc99c38716f07666463182511c54a5 100644
>--- a/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h
>+++ b/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h
>@@ -83,9 +83,11 @@ public:
> 
>     bool inspectorStartsAttached();
>     void setInspectorStartsAttached(bool);
>+    void deleteInspectorStartsAttached();
> 
>     bool inspectorAttachDisabled();
>     void setInspectorAttachDisabled(bool);
>+    void deleteInspectorAttachDisabled();
> 
>     void windowFullScreenDidChange();
> 
>@@ -119,6 +121,7 @@ public:
>     void bringToFront() override;
>     void closeWindow() override;
>     void reopen() override;
>+    void resetState() override;
> 
>     void attachWindow(DockSide) override;
>     void detachWindow() override;
>diff --git a/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm b/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm
>index 1b903af8b4cafe2a9b56f7128c7e40b92acb68b6..1c008097692ff9b071fce5ac4a4b4692d137ed95 100644
>--- a/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm
>+++ b/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm
>@@ -256,6 +256,17 @@ void WebInspectorFrontendClient::reopen()
>     [inspector show:nil];
> }
> 
>+void WebInspectorFrontendClient::resetState()
>+{
>+    InspectorFrontendClientLocal::resetState();
>+
>+    auto* inspectorClient = [m_frontendWindowController inspectorClient];
>+    inspectorClient->deleteInspectorStartsAttached();
>+    inspectorClient->deleteInspectorAttachDisabled();
>+
>+    [NSWindow removeFrameUsingName:[[m_frontendWindowController window] frameAutosaveName]];
>+}
>+
> void WebInspectorFrontendClient::attachWindow(DockSide)
> {
>     if ([m_frontendWindowController.get() attached])
>diff --git a/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.cpp b/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.cpp
>index a0d769d21d3ac04355e96a9cf2db46ef65fdb54d..e4dc75e3c9f54cdc1e4e2e2834bf3b004761577f 100644
>--- a/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.cpp
>+++ b/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.cpp
>@@ -278,6 +278,14 @@ void WebInspectorFrontendClient::reopen()
>         inspectedPage->inspectorController().show();
> }
> 
>+void WebInspectorFrontendClient::resetState()
>+{
>+    InspectorFrontendClientLocal::resetState();
>+
>+    m_inspectorClient->deleteInspectorStartsAttached();
>+    m_inspectorClient->deleteInspectorAttachDisabled();
>+}
>+
> void WebInspectorFrontendClient::attachWindow(DockSide)
> {
>     if (m_attached)
>diff --git a/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.h b/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.h
>index 1733a7272f802799739b20c2b0f05a5abcf8a40e..95c9afa85002a543270b7ce6b388c70d48918518 100644
>--- a/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.h
>+++ b/Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.h
>@@ -68,9 +68,11 @@ public:
> 
>     bool inspectorStartsAttached();
>     void setInspectorStartsAttached(bool);
>+    void deleteInspectorStartsAttached();
> 
>     bool inspectorAttachDisabled();
>     void setInspectorAttachDisabled(bool);
>+    void deleteInspectorAttachDisabled();
> 
>     void releaseFrontend();
> 
>@@ -104,6 +106,7 @@ public:
>     void bringToFront() override;
>     void closeWindow() override;
>     void reopen() override;
>+    void resetState() override;
> 
>     void setAttachedWindowHeight(unsigned) override;
>     void setAttachedWindowWidth(unsigned) override;

Flags:

mattbaker: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198956: 372400 | 372403 | 372412 | 373309