Attachment 372375 Details for Bug 198975 – Patch

[patch] Patch

bug-198975-20190618233941.patch (text/plain), 3.92 KB, created by Alexey Shvayka on 2019-06-18 13:39:43 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Shvayka

Created: 2019-06-18 13:39:43 PDT

Size: 3.92 KB

patch

obsolete

>Index: JSTests/ChangeLog
>===================================================================
>--- JSTests/ChangeLog	(revision 246561)
>+++ JSTests/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-06-18  Alexey Shvayka  <shvaikalesh@gmail.com>
>+
>+        Non-standard Error properties should not be enumerable
>+        https://bugs.webkit.org/show_bug.cgi?id=198975
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * test262/expectations.yaml: Mark 6 test cases as passing.
>+
> 2019-06-18  Tadeu Zagallo  <tzagallo@apple.com>
> 
>         DFG code should not reify the names of builtin functions with private names
>Index: JSTests/test262/expectations.yaml
>===================================================================
>--- JSTests/test262/expectations.yaml	(revision 246561)
>+++ JSTests/test262/expectations.yaml	(working copy)
>@@ -1067,15 +1067,6 @@ test/built-ins/Number/prototype/toFixed/
> test/built-ins/Number/prototype/toPrecision/range.js:
>   default: 'RangeError: toPrecision() argument must be between 1 and 21'
>   strict mode: 'RangeError: toPrecision() argument must be between 1 and 21'
>-test/built-ins/Object/defineProperties/15.2.3.7-2-15.js:
>-  default: 'TypeError: Property description must be an object.'
>-  strict mode: 'TypeError: Property description must be an object.'
>-test/built-ins/Object/defineProperties/15.2.3.7-5-a-16.js:
>-  default: 'TypeError: Property description must be an object.'
>-  strict mode: 'TypeError: Property description must be an object.'
>-test/built-ins/Object/defineProperties/15.2.3.7-5-b-248.js:
>-  default: 'TypeError: Property description must be an object.'
>-  strict mode: 'TypeError: Property description must be an object.'
> test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-arguments.js:
>   default: 'Test262Error: Expected SameValue(ÃÂ«nullÃÂ», ÃÂ«[object Arguments]ÃÂ») to be true'
> test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-caller.js:
>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 246561)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-06-18  Alexey Shvayka  <shvaikalesh@gmail.com>
>+
>+        Non-standard Error properties should not be enumerable
>+        https://bugs.webkit.org/show_bug.cgi?id=198975
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Define non-standard Error properties "line" and "column" as non-enumerable.
>+
>+        * runtime/ErrorInstance.cpp:
>+        (JSC::ErrorInstance::materializeErrorInfoIfNeeded):
>+
> 2019-06-18  Tadeu Zagallo  <tzagallo@apple.com>
> 
>         DFG code should not reify the names of builtin functions with private names
>Index: Source/JavaScriptCore/runtime/ErrorInstance.cpp
>===================================================================
>--- Source/JavaScriptCore/runtime/ErrorInstance.cpp	(revision 246561)
>+++ Source/JavaScriptCore/runtime/ErrorInstance.cpp	(working copy)
>@@ -238,12 +238,14 @@ bool ErrorInstance::materializeErrorInfo
>     computeErrorInfo(vm);
> 
>     if (!m_stackString.isNull()) {
>-        putDirect(vm, vm.propertyNames->line, jsNumber(m_line));
>-        putDirect(vm, vm.propertyNames->column, jsNumber(m_column));
>+        auto attributes = static_cast<unsigned>(PropertyAttribute::DontEnum);
>+
>+        putDirect(vm, vm.propertyNames->line, jsNumber(m_line), attributes);
>+        putDirect(vm, vm.propertyNames->column, jsNumber(m_column), attributes);
>         if (!m_sourceURL.isEmpty())
>-            putDirect(vm, vm.propertyNames->sourceURL, jsString(&vm, WTFMove(m_sourceURL)));
>+            putDirect(vm, vm.propertyNames->sourceURL, jsString(&vm, WTFMove(m_sourceURL)), attributes);
> 
>-        putDirect(vm, vm.propertyNames->stack, jsString(&vm, WTFMove(m_stackString)), static_cast<unsigned>(PropertyAttribute::DontEnum));
>+        putDirect(vm, vm.propertyNames->stack, jsString(&vm, WTFMove(m_stackString)), attributes);
>     }
> 
>     m_errorInfoMaterialized = true;

Actions: View | Formatted Diff | Diff

Attachments on bug 198975: 372375 | 372384 | 372385 | 372392 | 372395 | 372410 | 372451 | 379739