Attachment 372360 Details for Bug 198973 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

deflate.patch (text/plain), 1.23 KB, created by Joseph Pecoraro on 2019-06-18 12:10:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-06-18 12:10:06 PDT

Size: 1.23 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c16c181ce3a..59942865dbd 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-18  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        WebSocketDeflater uses an unnecessarily constrained compression memory level
>+        https://bugs.webkit.org/show_bug.cgi?id=198973
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Modules/websockets/WebSocketDeflater.cpp:
>+        Set the memLevel to the deflateInit2 default value, not a minimum value.
>+
> 2019-06-18  Saam Barati  <sbarati@apple.com>
> 
>         [WHLSL] Do not generate duplicate constructors/copy constructors in synthesizeConstructors
>diff --git a/Source/WebCore/Modules/websockets/WebSocketDeflater.cpp b/Source/WebCore/Modules/websockets/WebSocketDeflater.cpp
>index 7d3971d5796..1d6f17822c8 100644
>--- a/Source/WebCore/Modules/websockets/WebSocketDeflater.cpp
>+++ b/Source/WebCore/Modules/websockets/WebSocketDeflater.cpp
>@@ -43,7 +43,7 @@
> 
> namespace WebCore {
> 
>-static const int defaultMemLevel = 1;
>+static const int defaultMemLevel = 8;
> static const size_t bufferIncrementUnit = 4096;
> 
> WebSocketDeflater::WebSocketDeflater(int windowBits, ContextTakeOverMode contextTakeOverMode)

Actions: View | Formatted Diff | Diff

Attachments on bug 198973: 372360