Attachment 372345 Details for Bug 198968 – Patch

[patch] Patch

file_198968.txt (text/plain), 2.68 KB, created by David Quesada on 2019-06-18 10:08:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Quesada

Created: 2019-06-18 10:08:20 PDT

Size: 2.68 KB

patch

obsolete

>commit 145b0280bc4e4ebabc951a33a65e161d09d1b4ad
>Author: David Quesada <david_quesada@apple.com>
>Date:   Tue Jun 18 10:06:04 2019 -0700
>
>    Network process crash in SandboxExtension::consume() via Download::publishProgress
>    https://bugs.webkit.org/show_bug.cgi?id=198968
>    rdar://problem/51732997
>    
>    Reviewed by NOBODY (OOPS!).
>    
>    Add an early return if the network process fails to resolve a sandbox extension handle for publishing
>    progress on a download. Creating the NSProgress doesn't do much since the progress reporting service
>    won't honor the attempt to publish progress on a URL the process does not have access to, and nothing
>    else in the Network process makes any use of the progress.
>    
>    * NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
>    (WebKit::Download::publishProgress):
>
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 5295e9b0c12..c24af23b486 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-06-18  David Quesada  <david_quesada@apple.com>
>+
>+        Network process crash in SandboxExtension::consume() via Download::publishProgress
>+        https://bugs.webkit.org/show_bug.cgi?id=198968
>+        rdar://problem/51732997
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add an early return if the network process fails to resolve a sandbox extension handle for publishing
>+        progress on a download. Creating the NSProgress doesn't do much since the progress reporting service
>+        won't honor the attempt to publish progress on a URL the process does not have access to, and nothing
>+        else in the Network process makes any use of the progress.
>+
>+        * NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
>+        (WebKit::Download::publishProgress):
>+
> 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
> 
>         Ensure ITP state is relayed to Network Process on restart
>diff --git a/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm b/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm
>index 9bcf128b8be..c7c514b7e17 100644
>--- a/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm
>+++ b/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm
>@@ -108,6 +108,8 @@ void Download::publishProgress(const URL& url, SandboxExtension::Handle&& sandbo
>     auto sandboxExtension = SandboxExtension::create(WTFMove(sandboxExtensionHandle));
> 
>     ASSERT(sandboxExtension);
>+    if (!sandboxExtension)
>+        return;
> 
>     m_progress = adoptNS([[WKDownloadProgress alloc] initWithDownloadTask:m_downloadTask.get() download:this URL:(NSURL *)url sandboxExtension:sandboxExtension]);
> #if USE(NSPROGRESS_PUBLISHING_SPI)

Actions: View | Formatted Diff | Diff

Attachments on bug 198968: 372345