Attachment 372326 Details for Bug 198952 – Patch

[patch] Patch

bug-198952-20190617222309.patch (text/plain), 2.98 KB, created by Devin Rousso on 2019-06-17 22:23:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-17 22:23:09 PDT

Size: 2.98 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index d8a0087b090b84c273c215a6ed018e360ba099a7..4fd7db4c6dde31635e45bee6312a3e0de39450cb 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-06-17  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Canvas: the initial state should be selected when processing a new/imported recording if the navigation sidebar is collapsed
>+        https://bugs.webkit.org/show_bug.cgi?id=198952
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Prevent any content from being generated until `initialLayout` is called, as otherwise it's
>+        possible for the `CanvasNavigationSidebar` to update the current action index before the
>+        preview element has been created, which would throw an error.
>+
>+        * UserInterface/Views/RecordingContentView.js:
>+        (WI.RecordingContentView.prototype.updateActionIndex):
>+        (WI.RecordingContentView.prototype.initialLayout):
>+        (WI.RecordingContentView.prototype._updateSliderValue):
>+        (WI.RecordingContentView.prototype._handleRecordingProcessedAction):
>+        Drive-by: update the slider max each time the selected action index is changed.
>+
> 2019-06-17  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: Elements: remove ellipses from "Break on" context menu item title
>diff --git a/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js b/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js
>index 41e8803a09d56e96922b202a5c905740dde830e9..10ece2083b937ffe9574a62e2620ad1705656927 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js
>@@ -111,7 +111,8 @@ WI.RecordingContentView = class RecordingContentView extends WI.ContentView
> 
>         this._updateSliderValue();
> 
>-        this._generateContentThrottler.fire();
>+        if (this.didInitialLayout)
>+            this._generateContentThrottler.fire();
> 
>         this._action = this.representedObject.actions[this._index];
> 
>@@ -179,6 +180,9 @@ WI.RecordingContentView = class RecordingContentView extends WI.ContentView
>         }
> 
>         this._updateSliderValue();
>+
>+        if (!isNaN(this._index))
>+            this._generateContentThrottler.fire();
>     }
> 
>     // Private
>@@ -483,6 +487,7 @@ WI.RecordingContentView = class RecordingContentView extends WI.ContentView
>         }
> 
>         this._sliderElement.value = visualActionIndex;
>+        this._sliderElement.max = visualActionIndexes.length;
>         this._sliderValueElement.textContent = WI.UIString("%d of %d").format(visualActionIndex, visualActionIndexes.length);
>     }
> 
>@@ -523,7 +528,6 @@ WI.RecordingContentView = class RecordingContentView extends WI.ContentView
>     {
>         this._updateExportButton();
> 
>-        this._sliderElement.max = this.representedObject.visualActionIndexes.length;
>         this._updateSliderValue();
> 
>         if (this.representedObject.ready)

Actions: View | Formatted Diff | Diff

Attachments on bug 198952: 372326