Attachment 372325 Details for Bug 198953 – Patch

[patch] Patch

bug-198953-20190617221030.patch (text/plain), 2.56 KB, created by Devin Rousso on 2019-06-17 22:10:30 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-17 22:10:30 PDT

Size: 2.56 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index d8a0087b090b84c273c215a6ed018e360ba099a7..278cc2f172159f165356882a805b6403dda1171a 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-06-17  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: REGRESSION: Canvas: cannot select saved recordings
>+        https://bugs.webkit.org/show_bug.cgi?id=198953
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/TreeElement.js:
>+        (WI.TreeElement.treeElementToggled):
>+        Don't early return if the `TreeElement` isn't `selectable` as the owner `TreeOutline` may
>+        want to dispatch an event that it was clicked.
>+
> 2019-06-17  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: Elements: remove ellipses from "Break on" context menu item title
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>index f6ae0469dc0b193daa9b22cee75f5efc3377716b..8724bd4ac3478422bab3eb493a91027a49511fc5 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>@@ -308,22 +308,20 @@ WI.TreeElement = class TreeElement extends WI.Object
>             return;
> 
>         let toggleOnClick = treeElement.toggleOnClick && !treeElement.selectable;
>-        let isInTriangle = treeElement.isEventWithinDisclosureTriangle(event);
>-        if (!toggleOnClick && !isInTriangle)
>-            return;
>-
>-        if (treeElement.expanded) {
>-            if (event.altKey)
>-                treeElement.collapseRecursively();
>-            else
>-                treeElement.collapse();
>-        } else {
>-            if (event.altKey)
>-                treeElement.expandRecursively();
>-            else
>-                treeElement.expand();
>+        if (toggleOnClick || treeElement.isEventWithinDisclosureTriangle(event)) {
>+            if (treeElement.expanded) {
>+                if (event.altKey)
>+                    treeElement.collapseRecursively();
>+                else
>+                    treeElement.collapse();
>+            } else {
>+                if (event.altKey)
>+                    treeElement.expandRecursively();
>+                else
>+                    treeElement.expand();
>+            }
>+            event.stopPropagation();
>         }
>-        event.stopPropagation();
> 
>         if (!treeElement.treeOutline.selectable)
>             treeElement.treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.ElementClicked, {treeElement});

Actions: View | Formatted Diff | Diff

Attachments on bug 198953: 372325