WebKit Bugzilla
Attachment 372323 Details for
Bug 198941
: Web Inspector: REGRESSION: Heap: subsequent snapshots taken manually don't appear in the list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-198941-20190617214753.patch (text/plain), 2.62 KB, created by
Devin Rousso
on 2019-06-17 21:47:54 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Devin Rousso
Created:
2019-06-17 21:47:54 PDT
Size:
2.62 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 079cf01a7766fee345c357b9489642eb5f01ccba..31096b7a1005fed2262425f57c1097fbab033fea 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,20 @@ >+2019-06-17 Devin Rousso <drousso@apple.com> >+ >+ Web Inspector: REGRESSION: Heap: subsequent snapshots taken manually don't appear in the list >+ https://bugs.webkit.org/show_bug.cgi?id=198941 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Since heap snapshot records can be added at any time, including when not actively recording, >+ when the "Entire Recording" range is selected, make sure to set the `filterEndTime` to be an >+ effectively infinite number so that records added later aren't filtered out. >+ >+ This isn't done for other timeline views as they may have graphs that don't expect to render >+ from time 0 till infinity, not to mention being unable to add records when not recording. >+ >+ * UserInterface/Views/TimelineRecordingContentView.js: >+ (WI.TimelineRecordingContentView.prototype._updateTimelineViewTimes): >+ > 2019-06-17 Devin Rousso <drousso@apple.com> > > Web Inspector: Settings: split the General panel into sub panels so it's less crowded >diff --git a/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js b/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js >index a6b7bd68522de7e10b6f7e6d5ccb8f7e845325d5..746513256e6d7ec60f681850f755e7ed6e7cb816 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js >+++ b/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js >@@ -836,8 +836,12 @@ WI.TimelineRecordingContentView = class TimelineRecordingContentView extends WI. > let endTime = this._timelineOverview.selectionStartTime + this._timelineOverview.selectionDuration; > > if (entireRangeSelected) { >- if (timelineView instanceof WI.RenderingFrameTimelineView) { >+ if (timelineView instanceof WI.RenderingFrameTimelineView) > endTime = this._renderingFrameTimeline.records.length; >+ else if (timelineView instanceof WI.HeapAllocationsTimelineView) { >+ // Since heap snapshots can be added at any time, including when not actively recording, >+ // make sure to set the end time to an effectively infinite number. >+ endTime = Number.MAX_VALUE; > } else { > // Clamp selection to the end of the recording (with padding), > // so graph views will show an auto-sized graph without a lot of
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198941
:
372323
|
372324