Attachment 372320 Details for Bug 198951 – Patch

[patch] Patch

bug-198951-20190617211943.patch (text/plain), 3.04 KB, created by Devin Rousso on 2019-06-17 21:19:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-17 21:19:44 PDT

Size: 3.04 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 079cf01a7766fee345c357b9489642eb5f01ccba..947805c81fc90397a6338c90f62d9cdd468c66f6 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-06-17  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Network: detail view shouldn't stay open when the related entry is removed
>+        https://bugs.webkit.org/show_bug.cgi?id=198951
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/NetworkTableContentView.js:
>+        (WI.NetworkTableContentView.prototype._mainResourceDidChange):
>+        Hide the detail view if the main resource changes and we aren't preserving the log.
>+
>+        * UserInterface/Views/Table.js:
>+        (WI.Table.prototype.reloadVisibleColumnCells):
>+        Only attempt to populate cells for rows that the `_dataSource` actually has. Without this,
>+        the `_delegate` may be asked to populate a cell for a row it doesn't have, which would error.
>+
> 2019-06-17  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Settings: split the General panel into sub panels so it's less crowded
>diff --git a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>index cffd1cf284c59a1fcd70310836d5eda86fb3532a..f58385ba229da8e0a87e629c372dd67c3a5549c2 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>@@ -1587,9 +1587,13 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
>     {
>         this._runForMainCollection((collection) => {
>             let frame = event.target;
>-            if (frame.isMainFrame() && WI.settings.clearNetworkOnNavigate.value)
>+            if (frame.isMainFrame() && WI.settings.clearNetworkOnNavigate.value) {
>                 this._resetCollection(collection);
> 
>+                if (!this._needsInitialPopulate)
>+                    this._hideDetailView();
>+            }
>+
>             if (this._transitioningPageTarget) {
>                 this._transitioningPageTarget = false;
>                 this._needsInitialPopulate = true;
>diff --git a/Source/WebInspectorUI/UserInterface/Views/Table.js b/Source/WebInspectorUI/UserInterface/Views/Table.js
>index 8215b2c09d4a2c616a32128889d27bb74208a7f5..ce9f0ea47852ca46ddb22ff77058ff1352e21e5a 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/Table.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/Table.js
>@@ -281,7 +281,8 @@ WI.Table = class Table extends WI.View
>         if (columnIndex === -1)
>             return;
> 
>-        for (let rowIndex = this._visibleRowIndexStart; rowIndex < this._visibleRowIndexEnd; ++rowIndex) {
>+        let numberOfRows = this.numberOfRows;
>+        for (let rowIndex = this._visibleRowIndexStart; rowIndex < Math.min(this._visibleRowIndexEnd, numberOfRows); ++rowIndex) {
>             let row = this._cachedRows.get(rowIndex);
>             if (!row)
>                 continue;

Actions: View | Formatted Diff | Diff

Attachments on bug 198951: 372320 | 372358