Attachment 372298 Details for Bug 198944 – Patch

[patch] Patch

bug-198944-20190617171755.patch (text/plain), 2.84 KB, created by Matt Baker on 2019-06-17 17:17:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2019-06-17 17:17:56 PDT

Size: 2.84 KB

patch

obsolete

>Subversion Revision: 246500
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 926b90cc67776b20e5fc5f9541c3d14024093263..2131ab3f13bf5688b977e62eb58d111d97caff5c 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-06-17  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: Elements: remove ellipses from "Break on" context menu item title
>+        https://bugs.webkit.org/show_bug.cgi?id=198944
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Update context menu title to comply with Apple HI guidelines.
>+
>+        * Localizations/en.lproj/localizedStrings.js:
>+        * UserInterface/Views/ContextMenuUtilities.js:
>+
> 2019-06-13  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: REGRESSION(r246178): extra spaces added in at-rules when formatting CSS
>diff --git a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>index 9a3c9ea4c4a35e98c0aa6440aee3fc91aae16296..315bd5f198bdb4a48f0bea7b409ed4ef59153017 100644
>--- a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>+++ b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>@@ -166,9 +166,9 @@ localizedStrings["Block Variables"] = "Block Variables";
> localizedStrings["Body:"] = "Body:";
> localizedStrings["Boundary"] = "Boundary";
> localizedStrings["Box Model"] = "Box Model";
>+localizedStrings["Break on"] = "Break on";
> localizedStrings["Break on events with name:"] = "Break on events with name:";
> localizedStrings["Break on request with URL:"] = "Break on request with URL:";
>-localizedStrings["Break on\u2026"] = "Break on\u2026";
> localizedStrings["Breakdown"] = "Breakdown";
> localizedStrings["Breakdown of each memory category at the end of the selected time range"] = "Breakdown of each memory category at the end of the selected time range";
> localizedStrings["Breakdown of time spent on the main thread"] = "Breakdown of time spent on the main thread";
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js b/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
>index da3dc633cdfcac6c0dcc703a867d4037156d6788..3e395c515a364b3fa1054429a30e69914e24021a 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
>@@ -291,7 +291,7 @@ WI.appendContextMenuItemsForDOMNodeBreakpoints = function(contextMenu, domNode,
> 
>     contextMenu.__domBreakpointItemsAdded = true;
> 
>-    let subMenu = contextMenu.appendSubMenuItem(WI.UIString("Break on\u2026"));
>+    let subMenu = contextMenu.appendSubMenuItem(WI.UIString("Break on"));
> 
>     let breakpoints = WI.domDebuggerManager.domBreakpointsForNode(domNode);
>     let keyValuePairs = breakpoints.map((breakpoint) => [breakpoint.type, breakpoint]);

Actions: View | Formatted Diff | Diff

Attachments on bug 198944: 372298