Attachment 372294 Details for Bug 187360 – Patch

[patch] Patch

bug-187360-20190617165759.patch (text/plain), 1.93 KB, created by Alex Christensen on 2019-06-17 16:58:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-06-17 16:58:00 PDT

Size: 1.93 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 246523)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,20 @@
>+2019-06-17  Alex Christensen  <achristensen@webkit.org>
>+
>+        Fix iOS crash when starting loads with no active DocumentLoader
>+        https://bugs.webkit.org/show_bug.cgi?id=187360
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When FrameLoader::activeDocumentLoader returns null in the ResourceLoader constructor,
>+        on iOS we will dereference it to ask if it has a frame in an early return in init.
>+        Let's not.  If we don't have a DocumentLoader, we don't have a frame and should fail.
>+
>+        Crash reports indicate this crash is related to Beacon and other uses of LoaderStrategy::startPingLoad,
>+        but attempts to make a unit test to reproduce the crash were unsuccessful.
>+
>+        * loader/ResourceLoader.cpp:
>+        (WebCore::ResourceLoader::init):
>+
> 2019-06-17  Robin Morisset  <rmorisset@apple.com>
> 
>         [WHLSL] Remove backtracking from parseAttributeBlock
>Index: Source/WebCore/loader/ResourceLoader.cpp
>===================================================================
>--- Source/WebCore/loader/ResourceLoader.cpp	(revision 246516)
>+++ Source/WebCore/loader/ResourceLoader.cpp	(working copy)
>@@ -119,6 +119,15 @@ void ResourceLoader::releaseResources()
> 
> void ResourceLoader::init(ResourceRequest&& clientRequest, CompletionHandler<void(bool)>&& completionHandler)
> {
>+#if PLATFORM(IOS_FAMILY)
>+    if (!m_documentLoader) {
>+        // We should always have a DocumentLoader at this point, but crash reports indicate that it is sometimes null.
>+        // See https://bugs.webkit.org/show_bug.cgi?id=187360
>+        ASSERT_NOT_REACHED();
>+        cancel();
>+        return completionHandler(false);
>+    }
>+#endif
>     ASSERT(!m_handle);
>     ASSERT(m_request.isNull());
>     ASSERT(m_deferredRequest.isNull());

Flags:

ggaren: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 187360: 344355 | 372294